[ACS-10280]: cleans up redundant property

Author: rmnvch

lib/content-services/src/lib/document-list/data/share-datatable-adapter.spec.ts

@@ -493,16 +493,4 @@ describe('ShareDataTableAdapter', () => {
             expect(adapter.getRowByNodeId('fake-node-id-2')).toEqual(fakeShareDataRows[1]);
         });
     });
-
-    it('should initialize with allowFocusOnRows as true by default', () => {
-        const adapter = new ShareDataTableAdapter(thumbnailService, contentService, null);
-        expect(adapter.allowFocusOnRows).toBe(true);
-    });
-
-    it('should set allowFocusOnRows value', () => {
-        const adapter = new ShareDataTableAdapter(thumbnailService, contentService, null);
-        expect(adapter.allowFocusOnRows).toBe(true);
-        adapter.setAllowFocusOnTableRows(false);
-        expect(adapter.allowFocusOnRows).toBe(false);
-    });
 });

lib/content-services/src/lib/document-list/data/share-datatable-adapter.ts

@@ -38,7 +38,6 @@ export class ShareDataTableAdapter implements DataTableAdapter {
     permissionsStyle: PermissionStyleModel[];
     selectedRow: DataRow;
     allowDropFiles: boolean;
-    allowFocusOnRows = true;
 
     set sortingMode(value: string) {
         let newValue = (value || 'client').toLowerCase();
@@ -197,10 +196,6 @@ export class ShareDataTableAdapter implements DataTableAdapter {
         this.imageResolver = resolver;
     }
 
-    setAllowFocusOnTableRows(allow: boolean) {
-        this.allowFocusOnRows = allow;
-    }
-
     private getFolderIcon(node: any) {
         if (this.isSmartFolder(node)) {
             return this.thumbnailService.getMimeTypeIcon('smartFolder');

lib/core/src/lib/datatable/components/datatable/datatable.component.spec.ts

@@ -36,7 +36,6 @@ import { HarnessLoader } from '@angular/cdk/testing';
 import { ConfigurableFocusTrapFactory } from '@angular/cdk/a11y';
 import { provideRouter } from '@angular/router';
 import { firstValueFrom } from 'rxjs';
-import { DataTableAdapter } from '@alfresco/adf-core';
 import { MatTooltipHarness } from '@angular/material/tooltip/testing';
 
 @Component({
@@ -1818,47 +1817,6 @@ describe('Accessibility', () => {
         });
     });
 
-    describe('ShareDatatable adapter allowFocusOnRows', () => {
-        class ShareAdapterMock extends ObjectDataTableAdapter {
-            public allowFocusOnRows = true;
-
-            constructor(data: any[], schema: DataColumn[]) {
-                super(data, schema);
-            }
-
-            setAllowFocusOnTableRows(allow: boolean) {
-                this.allowFocusOnRows = allow;
-            }
-        }
-        const testAllowFocusOnRows = (expectedTabindex: string | null, adapter: DataTableAdapter) => {
-            const fakeDataRows = [new FakeDataRow(), new FakeDataRow()];
-
-            adapter.setRows(fakeDataRows);
-            dataTable.data = adapter;
-            fixture.detectChanges();
-            const rowElements = testingUtils.getAllByCSS('.adf-datatable-body adf-datatable-row');
-            expect(rowElements.length).toBeGreaterThan(0);
-            expect(rowElements.every((row) => row.nativeElement.getAttribute('tabindex') === expectedTabindex)).toBeTrue();
-        };
-
-        it('should set tabindex to null (disabled === true) on datatable-body rows when allowFocusOnRows is set to false in ShareDatatable adapter', () => {
-            const adapter = new ShareAdapterMock([], []);
-            adapter.setAllowFocusOnTableRows(false);
-            testAllowFocusOnRows(null, adapter);
-        });
-
-        it('should set tabindex to 0 (disabled === false) on datatable-body rows when allowFocusOnRows is not set explicitly in ShareDatatable adapter and falls back to default value ', () => {
-            const adapter = new ShareAdapterMock([], []);
-            adapter.setAllowFocusOnTableRows(true);
-            testAllowFocusOnRows('0', adapter);
-        });
-
-        it('should set tabindex to 0 (disabled === false) by default on datatable-body rows when allowFocusOnRows is not defined in Datatable adapter (fallback case)', () => {
-            const adapter = new ObjectDataTableAdapter([], []);
-            testAllowFocusOnRows('0', adapter);
-        });
-    });
-
     it('should create focus trap on main menu open', () => {
         dataTable.showHeader = ShowHeaderMode.Always;
         dataTable.showMainDatatableActions = true;

lib/core/src/lib/datatable/data/datatable-adapter.ts

@@ -22,7 +22,6 @@ import { Subject } from 'rxjs';
 
 export interface DataTableAdapter {
     rowsChanged?: Subject<Array<DataRow>>;
-    allowFocusOnRows?: boolean;
 
     selectedRow: DataRow;
     getRows(): Array<DataRow>;
@@ -34,5 +33,4 @@ export interface DataTableAdapter {
     getSorting(): DataSorting;
     setSorting(sorting: DataSorting): void;
     sort(key?: string, direction?: string): void;
-    setAllowFocusOnTableRows?(allow: boolean): void;
 }