AAE-28918 Fix start process button is enabled when required widgets are read only without value

Author: dthornton-hyl

lib/core/src/lib/form/components/widgets/core/form-field.model.spec.ts

@@ -1254,7 +1254,7 @@ describe('FormFieldModel', () => {
         expect(field.validate()).toBe(false);
     });
 
-    it('should NOT validate readOnly field if it is NOT validatable', () => {
+    it('should validate readOnly required field even if type is not in validatable list', () => {
         const form = new FormModel();
         const field = new FormFieldModel(form, {
             id: 'mockTextFieldId',
@@ -1267,8 +1267,60 @@ describe('FormFieldModel', () => {
         const validator = new RequiredFieldValidator();
         form.fieldValidators = [validator];
 
+        expect(FormFieldTypes.isValidatableType(FormFieldTypes.TEXT)).toBeFalse();
+        expect(field.validate()).toBe(false);
+    });
+
+    it('should pass validation for readOnly required field that has a value', () => {
+        const form = new FormModel();
+        const field = new FormFieldModel(form, {
+            id: 'mockTextFieldId',
+            type: FormFieldTypes.TEXT,
+            readOnly: true,
+            required: true,
+            value: 'some value'
+        });
+
+        const validator = new RequiredFieldValidator();
+        form.fieldValidators = [validator];
+
+        expect(field.validate()).toBe(true);
+    });
+
+    it('should skip validation for readOnly non-required field', () => {
+        const form = new FormModel();
+        const field = new FormFieldModel(form, {
+            id: 'mockTextFieldId',
+            type: FormFieldTypes.TEXT,
+            readOnly: true,
+            required: false,
+            value: null
+        });
+
+        const validator = new RequiredFieldValidator();
+        form.fieldValidators = [validator];
+
+        expect(field.validate()).toBe(true);
+    });
+
+    it('should pass validation for readOnly required field with empty value when field or parent is hidden', () => {
+        const form = new FormModel();
+        const field = new FormFieldModel(form, {
+            id: 'mockTextFieldId',
+            type: FormFieldTypes.TEXT,
+            readOnly: true,
+            required: true,
+            value: null
+        });
+
+        const validator = new RequiredFieldValidator();
+        form.fieldValidators = [validator];
+
+        spyOn(form, 'isFieldOrParentHidden').and.returnValue(true);
+
         expect(FormFieldTypes.isValidatableType(FormFieldTypes.TEXT)).toBeFalse();
         expect(field.validate()).toBe(true);
+        expect(form.isFieldOrParentHidden).toHaveBeenCalledWith(field);
     });
 
     it('should set the tooltip correctly', () => {

lib/core/src/lib/form/components/widgets/core/form-field.model.ts

@@ -178,6 +178,9 @@ export class FormFieldModel extends FormWidgetModel {
                     return this._isValid;
                 }
             }
+        } else if (this.readOnly && this._required && !this.form?.isFieldOrParentHidden(this) && this.isValueEmpty()) {
+            this._isValid = false;
+            return this._isValid;
         }
         this._isValid = true;
         return this._isValid;
@@ -187,6 +190,22 @@ export class FormFieldModel extends FormWidgetModel {
         return !this.readOnly || FormFieldTypes.isValidatableType(this.type);
     }
 
+    private isValueEmpty(): boolean {
+        if (this.value === null || this.value === undefined || this.value === '') {
+            return true;
+        }
+        if (typeof this.value === 'string' && this.value.trim().length === 0) {
+            return true;
+        }
+        if (this.type === FormFieldTypes.BOOLEAN) {
+            return !this.value;
+        }
+        if (Array.isArray(this.value)) {
+            return this.value.length === 0;
+        }
+        return false;
+    }
+
     constructor(form: any, json?: any, parent?: RepeatableSectionModel) {
         super(form, json);
         if (json) {