Skip to content

Commit 24d003a

Browse files
authored
correcting the logical PID of hwloc (#41)
1 parent 6f49ccb commit 24d003a

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

include/hicr/backends/hwloc/computeResource.hpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -147,12 +147,6 @@ class ComputeResource final : public HiCR::ComputeResource
147147
hwloc_obj_t obj = hwloc_get_obj_by_type(topology, HWLOC_OBJ_PU, objectId);
148148
if (!obj) HICR_THROW_RUNTIME("Attempting to access a compute resource that does not exist (%u) in this backend", objectId);
149149

150-
// Acquire the parent core object
151-
// There is an asumption here that a HWLOC_OBJ_PU type always has a parent of type HWLOC_OBJ_CORE,
152-
// which is consistent with current HWloc, but maybe reconsider it.
153-
obj = obj->parent;
154-
if (obj->type != HWLOC_OBJ_CORE) HICR_THROW_RUNTIME("Unexpected hwloc object type while trying to access Core/CPU (%u)", objectId);
155-
156150
return obj->logical_index;
157151
}
158152

@@ -168,12 +162,6 @@ class ComputeResource final : public HiCR::ComputeResource
168162
hwloc_obj_t obj = hwloc_get_obj_by_type(topology, HWLOC_OBJ_PU, objectId);
169163
if (!obj) HICR_THROW_RUNTIME("Attempting to access a compute resource that does not exist (%u) in this backend", objectId);
170164

171-
// Acquire the parent core object
172-
// There is an asumption here that a HWLOC_OBJ_PU type always has a parent of type HWLOC_OBJ_CORE,
173-
// which is consistent with current HWloc, but maybe reconsider it.
174-
obj = obj->parent;
175-
if (obj->type != HWLOC_OBJ_CORE) HICR_THROW_RUNTIME("Unexpected hwloc object type while trying to access Core/CPU (%u)", objectId);
176-
177165
return obj->os_index;
178166
}
179167

0 commit comments

Comments
 (0)