Skip to content

Commit b746950

Browse files
committed
Resolving a few more merge issues. Now running and passing all 163/163 tests with ctest -R _zero
1 parent b46bf4f commit b746950

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ if ( LIB_MATH AND LIB_DL AND MPI_FOUND )
176176

177177
if (ENABLE_IBVERBS)
178178
list(APPEND ENGINES "ibverbs")
179+
list(APPEND ENGINES "zero")
179180
endif()
180181

181182
endif()

src/MPI/CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,10 @@ if (MPI_FOUND)
196196
add_gtest( ibverbs_test "ibverbs" ON ${CMAKE_CURRENT_SOURCE_DIR}/ibverbs.t.cpp
197197
${CMAKE_CURRENT_SOURCE_DIR}/ibverbs.cpp
198198
${CMAKE_CURRENT_SOURCE_DIR}/mpilib.cpp)
199+
200+
add_gtest( zero_test "zero" ON ${CMAKE_CURRENT_SOURCE_DIR}/ibverbs.t.cpp
201+
${CMAKE_CURRENT_SOURCE_DIR}/ibverbsZero.cpp
202+
${CMAKE_CURRENT_SOURCE_DIR}/mpilib.cpp)
199203
endif()
200204

201205
foreach (engine ${MPI_ENGINES})

tests/functional/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,13 @@ foreach (LPF_IMPL_ID ${ENGINES})
141141
# zero engine does not support that
142142
string(REGEX MATCH "overlapping|early|bsplib" foundTest ${testSource})
143143
if (NOT ${LPF_IMPL_ID} STREQUAL "zero")
144-
add_gtest_mpi(${exeName} ${LPF_IMPL_ID} ${debug} FALSE "${CMAKE_CURRENT_SOURCE_DIR}/${testSource}")
144+
add_gtest(${exeName} ${LPF_IMPL_ID} ${debug} "${CMAKE_CURRENT_SOURCE_DIR}/${testSource}")
145145

146146
string(REGEX REPLACE "(.${LPF_IMPL_ID})?.cpp$" "" baseName ${testSource})
147147
get_filename_component(baseName ${testSource} NAME_WE )
148148
set(exeName "${baseName}_${LPF_IMPL_ID}_${LPF_IMPL_CONFIG}${mode}")
149149
elseif ("${foundTest}" STREQUAL "")
150-
add_gtest_mpi(${exeName} ${LPF_IMPL_ID} ${debug} FALSE "${CMAKE_CURRENT_SOURCE_DIR}/${testSource}")
150+
add_gtest(${exeName} ${LPF_IMPL_ID} ${debug} "${CMAKE_CURRENT_SOURCE_DIR}/${testSource}")
151151

152152
string(REGEX REPLACE "(.${LPF_IMPL_ID})?.cpp$" "" baseName ${testSource})
153153
get_filename_component(baseName ${testSource} NAME_WE )

tests/functional/func_lpf_probe_parallel_nested.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ void spmd1( lpf_t lpf, lpf_pid_t pid, lpf_pid_t nprocs, lpf_args_t args)
117117
EXPECT_LT( 0.0, (*(subMachine.g))(machine.p, (size_t)(-1), LPF_SYNC_DEFAULT) );
118118
EXPECT_LT( 0.0, (*(subMachine.l))(machine.p, (size_t)(-1), LPF_SYNC_DEFAULT) );
119119

120-
const int pthread = 1, mpirma = 1, mpimsg = 1, hybrid = 0, ibverbs=1;
121-
(void) pthread; (void) mpirma; (void) mpimsg; (void) hybrid; (void) ibverbs;
120+
const int pthread = 1, mpirma = 1, mpimsg = 1, hybrid = 0, ibverbs=1, zero = 1;
121+
(void) pthread; (void) mpirma; (void) mpimsg; (void) hybrid; (void) ibverbs; (void) zero;
122122
if (LPF_CORE_IMPL_ID) // this part is disabled for the hybrid implementation, because
123123
{ // that one doesn't do generic nesting of lpf_exec's
124124
EXPECT_EQ( 1, subMachine.free_p == 2 || subMachine.free_p == 3 );
@@ -203,5 +203,4 @@ TEST( API, func_lpf_probe_parallel_nested )
203203

204204
rc = lpf_exec( LPF_ROOT, machine.p / 2, &spmd1, args );
205205
EXPECT_EQ( LPF_SUCCESS, rc );
206-
207206
}

0 commit comments

Comments
 (0)