Correction to test for overflow in mtx reader

Christos Konstantinos Matzoros · Christos Konstantinos Matzoros · commit 40b1e12f74fd · 2025-10-13T16:50:57.000+02:00
diff --git a/include/osp/auxiliary/io/mtx_graph_file_reader.hpp b/include/osp/auxiliary/io/mtx_graph_file_reader.hpp
@@ -69,12 +69,12 @@ bool readComputationalDagMartixMarketFormat(std::ifstream& infile, Graph_t& grap
         return false;
     }
 
-    const vertex_t num_nodes = static_cast<vertex_t>(M_row);
-    if (num_nodes > std::numeric_limits<vertex_t>::max()) {
+    if (static_cast<unsigned long long>(M_row) > std::numeric_limits<vertex_t>::max()) {
         std::cerr << "Error: Matrix dimension too large for vertex type.\n";
         return false;
     }
 
+    const vertex_t num_nodes = static_cast<vertex_t>(M_row);
     std::vector<int> node_work_wts(num_nodes, 0);
     std::vector<int> node_comm_wts(num_nodes, 1);
 

Original file line number	Diff line number	Diff line change
`@@ -69,12 +69,12 @@ bool readComputationalDagMartixMarketFormat(std::ifstream& infile, Graph_t& grap`
`69`	`69`	`return false;`
`70`	`70`	`}`
`71`	`71`
`72`		`- const vertex_t num_nodes = static_cast<vertex_t>(M_row);`
`73`		`- if (num_nodes > std::numeric_limits<vertex_t>::max()) {`
	`72`	`+ if (static_cast<unsigned long long>(M_row) > std::numeric_limits<vertex_t>::max()) {`
`74`	`73`	`std::cerr << "Error: Matrix dimension too large for vertex type.\n";`
`75`	`74`	`return false;`
`76`	`75`	`}`
`77`	`76`
	`77`	`+ const vertex_t num_nodes = static_cast<vertex_t>(M_row);`
`78`	`78`	`std::vector<int> node_work_wts(num_nodes, 0);`
`79`	`79`	`std::vector<int> node_comm_wts(num_nodes, 1);`
`80`	`80`