Skip to content

Commit 7d97b8c

Browse files
authored
revision vertex_range, removed container_iterator_adaptor.hpp (#53)
1 parent 1ad1f39 commit 7d97b8c

File tree

11 files changed

+210
-300
lines changed

11 files changed

+210
-300
lines changed

include/osp/bsp/model/BspArchitecture.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ limitations under the License.
3030
#include "osp/auxiliary/misc.hpp"
3131
#include "osp/concepts/computational_dag_concept.hpp"
3232
#include "osp/concepts/graph_traits.hpp"
33-
#include "osp/graph_implementations/vertex_iterator.hpp"
33+
#include "osp/graph_implementations/integral_range.hpp"
3434

3535
namespace osp {
3636

@@ -282,7 +282,7 @@ class BspArchitecture {
282282
}
283283
}
284284

285-
inline auto processors() const { return vertex_range<unsigned>(number_processors); }
285+
inline auto processors() const { return integral_range<unsigned>(number_processors); }
286286

287287
/**
288288
* @brief Computes the average communication cost of the BspArchitecture.

include/osp/graph_implementations/adj_list_impl/compact_sparse_graph.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ limitations under the License.
3131
#include "osp/concepts/constructable_computational_dag_concept.hpp"
3232
#include "osp/concepts/specific_graph_impl.hpp"
3333
#include "osp/graph_algorithms/directed_graph_edge_view.hpp"
34-
#include "osp/graph_implementations/vertex_iterator.hpp"
34+
#include "osp/graph_implementations/integral_range.hpp"
3535

3636
namespace osp {
3737

@@ -664,7 +664,7 @@ class Compact_Sparse_Graph {
664664
}
665665
}
666666

667-
inline auto vertices() const { return vertex_range<vertex_idx>(number_of_vertices); };
667+
inline auto vertices() const { return integral_range<vertex_idx>(number_of_vertices); };
668668

669669
inline vert_t num_vertices() const { return number_of_vertices; };
670670
inline edge_t num_edges() const { return number_of_edges; }

include/osp/graph_implementations/adj_list_impl/compact_sparse_graph_edge_desc.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class Compact_Sparse_Graph_EdgeDesc : public Compact_Sparse_Graph<keep_vertex_or
224224

225225

226226

227-
inline auto edges() const { return vertex_range<directed_edge_descriptor>(BaseT::number_of_edges); };
227+
inline auto edges() const { return integral_range<directed_edge_descriptor>(BaseT::number_of_edges); };
228228
inline directed_edge_descriptor edge(const vertex_idx &src, const vertex_idx &tgt) const {
229229
typename BaseT::Compact_Children_Edges::Children_range range = BaseT::csc_out_edges.children(src);
230230

@@ -240,7 +240,7 @@ class Compact_Sparse_Graph_EdgeDesc : public Compact_Sparse_Graph<keep_vertex_or
240240
inline vertex_idx source(const directed_edge_descriptor &edge) const { return BaseT::csc_out_edges.source(edge); };
241241
inline vertex_idx target(const directed_edge_descriptor &edge) const { return BaseT::csc_out_edges.target(edge); };
242242

243-
inline auto out_edges(const vertex_idx &vert) const { return vertex_range<directed_edge_descriptor>(BaseT::csc_out_edges.children_indx_begin(vert), BaseT::csc_out_edges.children_indx_begin(vert + 1)); };
243+
inline auto out_edges(const vertex_idx &vert) const { return integral_range<directed_edge_descriptor>(BaseT::csc_out_edges.children_indx_begin(vert), BaseT::csc_out_edges.children_indx_begin(vert + 1)); };
244244
inline auto in_edges(const vertex_idx &vert) const { return In_Edges_range(vert, *this, BaseT::csc_out_edges); };
245245

246246
template<typename RetT = edge_comm_weight_type>

include/osp/graph_implementations/adj_list_impl/computational_dag_edge_idx_vector_impl.hpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ limitations under the License.
2323
#include "osp/graph_algorithms/computational_dag_construction_util.hpp"
2424
#include <vector>
2525

26-
// #include "container_iterator_adaptor.hpp"
27-
2826
namespace osp {
2927

3028
template<typename v_impl>
@@ -160,7 +158,7 @@ class computational_dag_edge_idx_vector_impl {
160158
inline auto parents(vertex_idx v) const { return edge_source_range(in_edges_[v], *this); }
161159
inline auto children(vertex_idx v) const { return edge_target_range(out_edges_[v], *this); }
162160

163-
inline auto vertices() const { return vertex_range<vertex_idx>(static_cast<vertex_idx>(vertices_.size())); }
161+
inline auto vertices() const { return integral_range<vertex_idx>(static_cast<vertex_idx>(vertices_.size())); }
164162

165163
inline const std::vector<directed_edge_descriptor> &in_edges(vertex_idx v) const { return in_edges_[v]; }
166164
inline const std::vector<directed_edge_descriptor> &out_edges(vertex_idx v) const { return out_edges_[v]; }

include/osp/graph_implementations/adj_list_impl/computational_dag_vector_impl.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ limitations under the License.
2020
#include "osp/concepts/computational_dag_concept.hpp"
2121
#include "osp/concepts/directed_graph_edge_desc_concept.hpp"
2222
#include "osp/graph_algorithms/computational_dag_construction_util.hpp"
23-
#include "osp/graph_implementations/vertex_iterator.hpp"
23+
#include "osp/graph_implementations/integral_range.hpp"
2424
#include <vector>
2525

2626
namespace osp {
@@ -115,7 +115,7 @@ class computational_dag_vector_impl {
115115

116116
virtual ~computational_dag_vector_impl() = default;
117117

118-
inline auto vertices() const { return vertex_range<vertex_idx>(static_cast<vertex_idx>(vertices_.size())); }
118+
inline auto vertices() const { return integral_range<vertex_idx>(static_cast<vertex_idx>(vertices_.size())); }
119119

120120
inline vertex_idx num_vertices() const { return static_cast<vertex_idx>(vertices_.size()); }
121121

include/osp/graph_implementations/adj_list_impl/dag_vector_adapter.hpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ limitations under the License.
2020
#include "computational_dag_vector_impl.hpp"
2121
#include "osp/concepts/computational_dag_concept.hpp"
2222
#include "osp/graph_algorithms/computational_dag_construction_util.hpp"
23-
#include "osp/graph_implementations/container_iterator_adaptor.hpp"
24-
#include "osp/graph_implementations/vertex_iterator.hpp"
23+
#include "osp/graph_implementations/integral_range.hpp"
2524
#include <vector>
2625

2726
namespace osp {
@@ -127,7 +126,7 @@ class dag_vector_adapter {
127126
num_vertex_types_ = 1;
128127
}
129128

130-
inline auto vertices() const { return vertex_range<vertex_idx>(static_cast<vertex_idx>(vertices_.size())); }
129+
inline auto vertices() const { return integral_range<vertex_idx>(static_cast<vertex_idx>(vertices_.size())); }
131130

132131
inline vertex_idx num_vertices() const { return static_cast<vertex_idx>(vertices_.size()); }
133132

include/osp/graph_implementations/container_iterator_adaptor.hpp

Lines changed: 0 additions & 165 deletions
This file was deleted.

include/osp/graph_implementations/eigen_matrix_adapter/sparse_matrix.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ limitations under the License.
2424
#include "osp/concepts/directed_graph_concept.hpp"
2525
#include "osp/concepts/directed_graph_edge_desc_concept.hpp"
2626
#include "osp/concepts/computational_dag_concept.hpp"
27-
#include "osp/graph_implementations/vertex_iterator.hpp"
27+
#include "osp/graph_implementations/integral_range.hpp"
2828
#include "eigen_sparse_iterator.hpp"
2929

3030
namespace osp {
@@ -72,7 +72,7 @@ class SparseMatrixImp {
7272

7373
/// @brief Return a range over all vertices [0, num_vertices)
7474
auto vertices() const {
75-
return osp::vertex_range<size_t>(num_vertices());
75+
return osp::integral_range<size_t>(num_vertices());
7676
}
7777

7878
/// @brief Number of edges = total non-zeros minus diagonal elements

0 commit comments

Comments
 (0)