fun with (more) flags

Author: tonibohnlein

CMakeLists.txt

@@ -31,24 +31,62 @@ add_subdirectory(.githooks)
 # --- Compile Options Configuration ---
 # Common compile options including strict warnings and error-on-warning
 set(COMMON_CXX_WARNING_FLAGS
-    "-Wall"
-    "-Wextra"
     "-Wfatal-errors"
     "-Wconversion"
     "-Wsign-conversion"
-    "-Wunused"
     "-Wunreachable-code"
     "-Wuninitialized"
-    "-Wshadow"
-    "-Wfloat-equal"
-    "-Wnon-virtual-dtor"
     "-pedantic"
     "-Wpedantic"
     "-Wold-style-cast"
     "-Wcast-align"
+    "-Werror"
+    "-Wall"
+    "-Wextra"
+    "-Wundef"
+    "-Wunused"
+    "-Wcast-qual"
+    "-Wpointer-arith"
+    "-Wdate-time"
+    "-Wfloat-equal"
+    "-Wformat=2"
+    "-Wshadow"
+    "-Wsign-compare"
+    "-Wunused-macros"
+    "-Wvla"
+    "-Wdisabled-optimization"
+    "-Wempty-body"
+    "-Wignored-qualifiers"
+    "-Wtype-limits"
+    "-Wshift-negative-value"
+    "-Wswitch-default"
+    "-Woverloaded-virtual"
+    "-Wnon-virtual-dtor"
+    "-Wshift-overflow=2"
+    "-Wshift-count-overflow"
+    "-Wwrite-strings"
+    "-Wmissing-format-attribute"
+    "-Wformat-nonliteral"
     "-Wduplicated-cond"
+    "-Wtrampolines"
+    "-Wsized-deallocation"
+    "-Wlogical-op"
+    "-Wsuggest-attribute=format"
     "-Wduplicated-branches"
-    "-Werror"
+    "-Wmissing-include-dirs"
+    "-Wformat-signedness"
+    "-Wreturn-local-addr"
+    "-Wredundant-decls"
+    "-Wfloat-conversion"
+    "-fno-common"
+    "-fno-strict-aliasing"
+    "-Wno-return-type"
+    "-Wno-array-bounds"
+    "-Wno-maybe-uninitialized"
+    "-Wno-unused-but-set-variable"
+    "-Wno-unused-variable"
+    "-Wno-unused-parameter"
+    "-Wno-unused-result"
 )
 
 # --- Project-specific Compile Flags ---

include/osp/auxiliary/io/arch_file_reader.hpp

@@ -73,6 +73,9 @@ bool readBspArchitecture(std::ifstream &infile, BspArchitecture<Graph_t> &archit
                 architecture.setMemoryConstraintType(MEMORY_CONSTRAINT_TYPE::PERSISTENT_AND_TRANSIENT);
                 architecture.setMemoryBound(static_cast<memw_t>(M));
                 break;
+            default:
+                std::cerr << "Invalid memory type.\n";
+                return false;
         }
     } else if (mem_type == -1) {
         std::cout << "No memory type specified. Assuming \"NONE\".\n";

include/osp/coarser/Sarkar/Sarkar.hpp

@@ -608,6 +608,12 @@ std::vector<std::vector<vertex_idx_t<Graph_t_in>>> Sarkar<Graph_t_in, Graph_t_ou
                 diff = homogeneous_buffer_merge(params.commCost, dag_in, expansionMap);
             }
             break;
+
+        default: // TODO check if it makes sense
+            {
+                diff = singleContraction(params.commCost, dag_in, expansionMap);
+            }
+            break;
     }
 
     // std::cout << " Diff: " << diff << '\n';

tests/CMakeLists.txt

@@ -11,7 +11,7 @@ macro( _add_test name )
   # Create the test
   add_executable(test_${name} ${name}.cpp)
   target_link_libraries(test_${name} PRIVATE OneStopParallel Boost::unit_test_framework ProjectExecutableFlags)
-  target_include_directories( test_${name} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/include )
+  target_include_directories( test_${name} PRIVATE ${PROJECT_SOURCE_DIR}/include )
 
   if(ARG_DATA)
     target_compile_definitions(test_${name} PRIVATE OSP_TEST_DATA_DIR="${OSP_DATA_DIR}")