Fix bug when passing nil headers to JSON convenience method

ndonald2 · AliSoftware · commit 2906c3a01475 · 2013-10-06T17:50:51.000+02:00
diff --git a/OHHTTPStubs/OHHTTPStubsResponse+JSON.m b/OHHTTPStubs/OHHTTPStubsResponse+JSON.m
@@ -18,9 +18,10 @@ + (instancetype)responseWithJSONObject:(id)jsonObject
 {
     if (!httpHeaders[@"Content-Type"])
     {
-        NSMutableDictionary *mutableHeaders = [httpHeaders mutableCopy];
+        // If httpHeaders is nil, we can't make a mutable copy.
+        NSMutableDictionary *mutableHeaders = httpHeaders ? [httpHeaders mutableCopy] : [NSMutableDictionary dictionary];
         mutableHeaders[@"Content-Type"] = @"application/json";
-        httpHeaders = mutableHeaders;
+        httpHeaders = [mutableHeaders copy]; // make immutable again
     }
     
     return [self responseWithData:[NSJSONSerialization dataWithJSONObject:jsonObject options:0 error:nil]

Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,10 @@ + (instancetype)responseWithJSONObject:(id)jsonObject`
`18`	`18`	`{`
`19`	`19`	`if (!httpHeaders[@"Content-Type"])`
`20`	`20`	`{`
`21`		`- NSMutableDictionary *mutableHeaders = [httpHeaders mutableCopy];`
	`21`	`+ // If httpHeaders is nil, we can't make a mutable copy.`
	`22`	`+ NSMutableDictionary *mutableHeaders = httpHeaders ? [httpHeaders mutableCopy] : [NSMutableDictionary dictionary];`
`22`	`23`	`mutableHeaders[@"Content-Type"] = @"application/json";`
`23`		`- httpHeaders = mutableHeaders;`
	`24`	`+ httpHeaders = [mutableHeaders copy]; // make immutable again`
`24`	`25`	`}`
`25`	`26`
`26`	`27`	`return [self responseWithData:[NSJSONSerialization dataWithJSONObject:jsonObject options:0 error:nil]`