Skip to content

Commit 17dd199

Browse files
committed
[alf] Assign services to card instead of endpoint level
1 parent c283955 commit 17dd199

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

src/AlfServer.cxx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -548,25 +548,25 @@ void AlfServer::makeRpcServers(std::vector<AlfLink> links)
548548
std::shared_ptr<roc::BarInterface> bar = link.bar;
549549

550550
if (link.cardType == roc::CardType::Cru) {
551-
if (link.linkId == 0) { // Register Read / Write services are per card; register them as soon as possible
551+
if (link.linkId == 0 && link.serialId.getEndpoint() == 0) { // Services per card
552552
// Register Read
553553
servers.push_back(makeServer(names.registerRead(),
554-
[bar](auto parameter) { return registerRead(parameter, bar); }));
554+
[bar](auto parameter) { return registerRead(parameter, bar); }));
555555
// Register Write
556556
servers.push_back(makeServer(names.registerWrite(),
557-
[bar](auto parameter) { return registerWrite(parameter, bar); }));
557+
[bar](auto parameter) { return registerWrite(parameter, bar); }));
558558

559559
// Pattern Player
560560
servers.push_back(makeServer(names.patternPlayer(),
561-
[bar](auto parameter) { return patternPlayer(parameter, bar); }));
561+
[bar](auto parameter) { return patternPlayer(parameter, bar); }));
562562

563563
// LLA Session Start
564564
servers.push_back(makeServer(names.llaSessionStart(),
565-
[link, this](auto parameter) { return llaSessionStart(parameter, link.serialId); }));
565+
[link, this](auto parameter) { return llaSessionStart(parameter, link.serialId); }));
566566

567567
// LLA Session Stop
568568
servers.push_back(makeServer(names.llaSessionStop(),
569-
[link, this](auto parameter) { return llaSessionStop(parameter, link.serialId); }));
569+
[link, this](auto parameter) { return llaSessionStop(parameter, link.serialId); }));
570570
}
571571

572572
lla::SessionParameters params = lla::SessionParameters::makeParameters()

src/DimServices/ServiceNames.cxx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,29 +31,30 @@ namespace alf
3131
#define DEFCARDSERVICENAME(_function, _name) \
3232
std::string ServiceNames::_function() const \
3333
{ \
34-
return format(_name); \
34+
return formatCard(_name); \
3535
}
3636

37-
DEFCARDSERVICENAME(registerRead, "REGISTER_READ")
38-
DEFCARDSERVICENAME(registerWrite, "REGISTER_WRITE")
3937
DEFCARDSERVICENAME(patternPlayer, "PATTERN_PLAYER")
4038
DEFCARDSERVICENAME(llaSessionStart, "LLA_SESSION_START")
4139
DEFCARDSERVICENAME(llaSessionStop, "LLA_SESSION_STOP")
40+
DEFCARDSERVICENAME(registerRead, "REGISTER_READ")
41+
DEFCARDSERVICENAME(registerWrite, "REGISTER_WRITE")
4242

43-
DEFLINKSERVICENAME(registerSequence, "REGISTER_SEQUENCE")
4443
DEFLINKSERVICENAME(scaSequence, "SCA_SEQUENCE")
4544
DEFLINKSERVICENAME(swtSequence, "SWT_SEQUENCE")
4645
DEFLINKSERVICENAME(icSequence, "IC_SEQUENCE")
4746
DEFLINKSERVICENAME(icGbtI2cWrite, "IC_GBT_I2C_WRITE")
47+
//CRORC
48+
DEFLINKSERVICENAME(registerSequence, "REGISTER_SEQUENCE")
4849

4950
std::string ServiceNames::formatLink(std::string name) const
5051
{
5152
return ((boost::format("ALF_%1%/SERIAL_%2%/ENDPOINT_%3%/LINK_%4%/%5%") % mAlfId % mSerialId.getSerial() % mSerialId.getEndpoint() % mLink % name)).str();
5253
}
5354

54-
std::string ServiceNames::format(std::string name) const
55+
std::string ServiceNames::formatCard(std::string name) const
5556
{
56-
return ((boost::format("ALF_%1%/SERIAL_%2%/ENDPOINT_%3%/%4%") % mAlfId % mSerialId.getSerial() % mSerialId.getEndpoint() % name)).str();
57+
return ((boost::format("ALF_%1%/SERIAL_%2%/%3%") % mAlfId % mSerialId.getSerial() % name)).str();
5758
}
5859

5960
} // namespace alf

src/DimServices/ServiceNames.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class ServiceNames
4646

4747
private:
4848
std::string formatLink(std::string name) const;
49-
std::string format(std::string name) const;
49+
std::string formatCard(std::string name) const;
5050
std::string mAlfId;
5151
const roc::SerialId mSerialId;
5252
const int mLink;

0 commit comments

Comments
 (0)