Skip to content

Commit 5347bc5

Browse files
committed
[alf] Remove confusing verbosity from error messages
1 parent 26f203a commit 5347bc5

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

apps/Alf.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class Alf : public AliceO2::Common::Program
9595
try {
9696
roc::FirmwareChecker().checkFirmwareCompatibility(card.pciAddress);
9797
} catch (const roc::Exception& e) {
98-
Logger::get().warn() << boost::diagnostic_information(e) << endm;
98+
Logger::get().warn() << e.what() << endm;
9999
continue;
100100
}
101101
}

src/DimServices/DimServices.cxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ void StringRpcServer::rpcHandler()
9292
auto returnValue = mCallback(std::string(getString()));
9393
setDataString(makeSuccessString(returnValue), *this);
9494
} catch (const std::exception& e) {
95-
Logger::get().log() << AliceO2::InfoLogger::InfoLogger::Error << mServiceName << ": " << boost::diagnostic_information(e, true)
96-
<< endm;
95+
Logger::get().err() << mServiceName << ": " << e.what() << endm;
9796
setDataString(makeFailureString(e.what()), *this);
9897
}
9998
}

src/Ic.cxx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,8 @@ std::vector<std::pair<Ic::Operation, Ic::Data>> Ic::executeSequence(std::vector<
238238
// the error message.
239239
IcData icData = boost::get<IcData>(data);
240240
std::string meaningfulMessage = (boost::format("ic_regs::IC_SEQUENCE address=0x%08x data=0x%08x serialId=%s link=%d, error='%s'") % icData.address % icData.data % mLink.serialId % mLink.linkId % e.what()).str();
241-
Logger::get().err() << meaningfulMessage << endm;
241+
//Logger::get().err() << meaningfulMessage << endm;
242+
242243
ret.push_back({ Operation::Error, meaningfulMessage });
243244
break;
244245
}

src/Sca.cxx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,8 @@ std::vector<std::pair<Sca::Operation, Sca::Data>> Sca::executeSequence(const std
300300
} else {
301301
meaningfulMessage = (boost::format("SCA_SEQUENCE UNKNOWN serialId=%s link=%d error='%s'") % mLink.serialId % mLink.linkId % e.what()).str();
302302
}
303-
Logger::get().err() << meaningfulMessage << endm;
303+
//Logger::get().err() << meaningfulMessage << endm;
304+
304305
ret.push_back({ Operation::Error, meaningfulMessage });
305306
break;
306307
}

src/Swt.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ std::vector<std::pair<Swt::Operation, Swt::Data>> Swt::executeSequence(std::vect
224224
} else {
225225
meaningfulMessage = (boost::format("SWT_SEQUENCE UNKNOWN serialId=%d link=%s, error='%s'") % mLink.serialId % mLink.linkId % e.what()).str();
226226
}
227-
Logger::get().err() << meaningfulMessage << endm;
227+
//Logger::get().err() << meaningfulMessage << endm;
228228

229229
ret.push_back({ Operation::Error, meaningfulMessage });
230230
break;

0 commit comments

Comments
 (0)