Skip to content

Commit 8a3690e

Browse files
ktflkrcal
authored andcommitted
More fixes for fmt 10.1.1
1 parent d132a0f commit 8a3690e

File tree

9 files changed

+16
-16
lines changed

9 files changed

+16
-16
lines changed

src/StfSender/StfSenderOutput.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ void StfSenderOutput::StfSchedulerThread()
497497
}
498498
default:
499499
{
500-
EDDLOG_RL(1000, "StfSchedulerThread: dropping STF of unknown type stf_source={}", lStf->header().mOrigin);
500+
EDDLOG_RL(1000, "StfSchedulerThread: dropping STF of unknown type stf_source={}", std::string_view((char const*)lStf->header().mOrigin, 4));
501501
mDropQueue.push(std::move(lStf));
502502
continue;
503503
break;

src/TfBuilder/TfBuilderInputUCX.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ void TfBuilderInputUCX::new_conn_handle(ucp_conn_request_h conn_request)
115115
DDDLOG("Received a connection request! addr={} port={}", lStfSenderAddr, lStfSenderPort);
116116

117117
if (mState.load() != CONFIGURING) {
118-
EDDLOG("Received a connection request but not in CONFIGURING state. state={}", mState.load());
118+
EDDLOG("Received a connection request but not in CONFIGURING state. state={}", (int)mState.load());
119119
return;
120120
}
121121

src/TfBuilder/TfBuilderRpc.cxx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ bool TfBuilderRpcImpl::sendTfBuilderUpdate()
265265
}
266266

267267
sUpdateCnt++;
268-
DDDLOG_RL(5000, "Sending TfBuilder update. accepting={} total={}", mAcceptingTfs, sUpdateCnt);
268+
DDDLOG_RL(5000, "Sending TfBuilder update. accepting={} total={}", mAcceptingTfs.load(), sUpdateCnt);
269269

270270
auto lRet = mTfSchedulerRpcClient.TfBuilderUpdate(lUpdate);
271271
if (!lRet && !mTerminateRequested && mRunning) {
@@ -391,7 +391,7 @@ ::grpc::Status TfBuilderRpcImpl::BuildTfRequest(::grpc::ServerContext* /*context
391391
assert (lTfId != 0);
392392

393393
sNumTfRequests++;
394-
DDDLOG_GRL(5000, "Requesting SubTimeFrames. tf_id={} tf_size={} total_requests={}", lTfId, lTfSize, sNumTfRequests);
394+
DDDLOG_GRL(5000, "Requesting SubTimeFrames. tf_id={} tf_size={} total_requests={}", lTfId, lTfSize, sNumTfRequests.load());
395395

396396
StfDataRequestMessage lStfRequest;
397397
const auto &lTfBuilderId = mDiscoveryConfig->status().info().process_id();
@@ -633,7 +633,7 @@ void TfBuilderRpcImpl::StfRequestGrpcThread()
633633

634634
if (!lStatus.ok()) {
635635
EDDLOG("StfSender gRPC connection problem. stfs_id={} code={} error={} stf_size={} timeout={}",
636-
lStfRequest.mRequest.stf_id(), lStfRequest.mStfSenderId, lStatus.error_code(), lStatus.error_message(), lStfRequest.mStfDataSize, (lStatus.error_code() == grpc::StatusCode::DEADLINE_EXCEEDED));
636+
lStfRequest.mRequest.stf_id(), lStfRequest.mStfSenderId, (int)lStatus.error_code(), lStatus.error_message(), lStfRequest.mStfDataSize, (lStatus.error_code() == grpc::StatusCode::DEADLINE_EXCEEDED));
637637
} else if (lStfResponse.status() != StfDataResponse::OK) {
638638
EDDLOG("StfSender did not send data. stf_id={} stfs_id={} reason={}",
639639
lStfRequest.mStfSenderId, StfDataResponse_StfDataStatus_Name(lStfResponse.status()));

src/TfScheduler/TfSchedulerConnManager.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ void TfSchedulerConnManager::ConnectTfBuilderUCXThread(const std::string lStfSen
355355
const auto lGrpcStatus = mStfSenderRpcClients.ConnectTfBuilderUCXRequest(lStfSenderId, lParam, lResponse);
356356
if(!lGrpcStatus.ok()) {
357357
IDDLOG_RL(1000, "TfBuilder UCX Connection error: gRPC error when connecting StfSender. stfs_id={} tfb_id={} err_code={} err={}",
358-
lStfSenderId, lTfBuilderId, lGrpcStatus.error_code(), lGrpcStatus.error_message());
358+
lStfSenderId, lTfBuilderId, (int)lGrpcStatus.error_code(), lGrpcStatus.error_message());
359359
lConnectionsOk = false;
360360
break;
361361
}
@@ -523,7 +523,7 @@ void TfSchedulerConnManager::DropStfThread()
523523
if (!lStatus.ok()) {
524524
// gRPC problem...
525525
WDDLOG_GRL(1000, "StfSender gRPC connection error. stfs_id={} code={} error={}",
526-
lStfSenderId, lStatus.error_code(), lStatus.error_message());
526+
lStfSenderId, (int)lStatus.error_code(), lStatus.error_message());
527527
}
528528

529529
if (lStfResponse.status() == StfDataResponse::DATA_DROPPED_TIMEOUT) {

src/TfScheduler/TfSchedulerInstanceRpc.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ ::grpc::Status TfSchedulerInstanceRpcImpl::TfBuilderUpdate(::grpc::ServerContext
347347

348348
sTfBuilderUpdates++;
349349
DDLOGF_GRL(30000, DataDistSeverity::debug, "gRPC server: TfBuilderUpdate. tfb_id={} total={}",
350-
request->info().process_id(), sTfBuilderUpdates);
350+
request->info().process_id(), sTfBuilderUpdates.load());
351351

352352
mTfBuilderInfo.updateTfBuilderInfo(*request);
353353

@@ -366,7 +366,7 @@ ::grpc::Status TfSchedulerInstanceRpcImpl::StfSenderStfUpdate(::grpc::ServerCont
366366

367367
sStfUpdates++;
368368
DDLOGF_GRL(30000, DataDistSeverity::debug, "gRPC server: StfSenderStfUpdate. stfs_id={} total={}",
369-
request->info().process_id(), sStfUpdates);
369+
request->info().process_id(), sStfUpdates.load());
370370

371371
response->Clear();
372372
mStfInfo.addStfInfo(*request, *response /*out*/);

src/TfScheduler/TfSchedulerStfInfo.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ void TfSchedulerStfInfo::StaleCleanupThread()
207207
mStaleStfTimeoutMs = std::clamp(mDiscoveryConfig->getUInt64Param(StaleTfTimeoutMsKey, StaleTfTimeoutMsDefault),
208208
std::uint64_t(250), std::uint64_t(60000));
209209

210-
IDDLOG("Parameter updated (consul) {}={}", StaleTfTimeoutMsKey, mStaleStfTimeoutMs);
210+
IDDLOG("Parameter updated (consul) {}={}", StaleTfTimeoutMsKey, mStaleStfTimeoutMs.load());
211211

212212
while (mRunning) {
213213

@@ -217,7 +217,7 @@ void TfSchedulerStfInfo::StaleCleanupThread()
217217
std::uint64_t(25), std::uint64_t(60000));
218218
if (lStaleStfTimeoutMs != mStaleStfTimeoutMs) {
219219
mStaleStfTimeoutMs = lStaleStfTimeoutMs;
220-
IDDLOG("Parameter updated (consul) {}={}", StaleTfTimeoutMsKey, mStaleStfTimeoutMs);
220+
IDDLOG("Parameter updated (consul) {}={}", StaleTfTimeoutMsKey, mStaleStfTimeoutMs.load());
221221
}
222222

223223
{

src/TfScheduler/TfSchedulerTfBuilderInfo.cxx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,18 +173,18 @@ bool TfSchedulerTfBuilderInfo::findTfBuilderForTf(const std::uint64_t pSize, std
173173
DDMON("tfscheduler", "tf.rejected.no_tfb_inst", mNoTfBuilderAvailable);
174174

175175
WDDLOG_RL(10000, "FindTfBuilder: TF cannot be scheduled. reason=NO_TFBUILDERS total={}",
176-
mNoTfBuilderAvailable);
176+
mNoTfBuilderAvailable.load());
177177

178178
} else if (lMaxTfExceeded) {
179179
++mTfNumExceeeded;
180180
WDDLOG_RL(10000, "FindTfBuilder: TF cannot be scheduled. reason=NUM_TF_EXCEEEDED total={} tf_size={} ready_tfb={}",
181-
mTfNumExceeeded, lTfEstSize, mReadyTfBuilders.size());
181+
mTfNumExceeeded.load(), lTfEstSize, mReadyTfBuilders.size());
182182
DDMON("tfscheduler", "tf.rejected.max_tf_exceeded", mTfNumExceeeded);
183183
} else if (lNoMemory) {
184184
++mNoMemoryAvailable;
185185
DDMON("tfscheduler", "tf.rejected.no_tfb_buf", mNoMemoryAvailable);
186186
WDDLOG_RL(10000, "FindTfBuilder: TF cannot be scheduled. reason=NO_MEMORY total={} tf_size={} ready_tfb={}",
187-
mNoMemoryAvailable, lTfEstSize, mReadyTfBuilders.size());
187+
mNoMemoryAvailable.load(), lTfEstSize, mReadyTfBuilders.size());
188188
}
189189
return false;
190190
}

src/TfScheduler/TfSchedulerTfBuilderInfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ class TfSchedulerTfBuilderInfo
176176
const auto lNewVal = std::clamp(pMaxTfsInBuilding, std::size_t(1), std::size_t(512));
177177

178178
if (mMaxTfsInBuilding != lNewVal) {
179-
IDDLOG("Parameter Update: MaxTfsInBuilding old_value={} new_value={}", mMaxTfsInBuilding, lNewVal);
179+
IDDLOG("Parameter Update: MaxTfsInBuilding old_value={} new_value={}", mMaxTfsInBuilding.load(), lNewVal);
180180
mMaxTfsInBuilding = lNewVal;
181181
}
182182
}

src/common/rpc/TfBuilderRpcClient.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class TfBuilderRpcClientCtx {
108108
return true;
109109
}
110110

111-
EDDLOG_RL(1000, "gRPC request error. code={} message={}", lStatus.error_code(), lStatus.error_message());
111+
EDDLOG_RL(1000, "gRPC request error. code={} message={}", (int)lStatus.error_code(), lStatus.error_message());
112112

113113
return false;
114114
}

0 commit comments

Comments
 (0)