Throw in case an FLP cannot connect, Now we have nmin, and in any case, a dead FLP should break the run

Author: davidrohr

src/common/rpc/StfSenderRpcClient.h

@@ -274,15 +274,14 @@ class StfSenderRpcClientCollection {
     }
 
     // test if actual connections are performing on StfSender
-    // NOTE: we cannot fail TfBuilder because the whole run will fail until nmin ODC/DDS is implemented
-    //       TfBuilder must be transition to Ready, but the input will be disabled
     bool lConnWorking = checkStfSenderRpcConn();
 
     auto lMsg = "StfSender gRPC connection finished. success={} failed={}";
     if (lConnWorking) {
       IDDLOG(lMsg, lConnWorking, getNumConnectedClients() - getNumWorkingClients());
     } else {
       EDDLOG(lMsg, lConnWorking, getNumConnectedClients() - getNumWorkingClients());
+      throw std::runtime_error("TfBuilder could not connect to all FLPs, terminating");
     }
 
     // only continue when all connections are established