Improve error handling of 99283b6, throw only in case of TfBuilder not TfScheduler

Author: davidrohr

src/TfScheduler/TfSchedulerConnManager.cxx

@@ -30,7 +30,7 @@ bool TfSchedulerConnManager::start()
 {
   using namespace std::chrono_literals;
 
-  if (!mStfSenderRpcClients.start()) {
+  if (!mStfSenderRpcClients.start(false)) {
     return false; // we'll be called back
   }
 

src/common/rpc/StfSenderRpcClient.h

@@ -188,7 +188,7 @@ class StfSenderRpcClientCollection {
 
   ~StfSenderRpcClientCollection() { if (mRunning) { stop(); } }
 
-  bool start()
+  bool start(bool failOnError = true)
   {
     using namespace std::chrono_literals;
     const auto &lPartId = mDiscoveryConfig->status().partition().partition_id();
@@ -281,7 +281,9 @@ class StfSenderRpcClientCollection {
       IDDLOG(lMsg, lConnWorking, getNumConnectedClients() - getNumWorkingClients());
     } else {
       EDDLOG(lMsg, lConnWorking, getNumConnectedClients() - getNumWorkingClients());
-      throw std::runtime_error("TfBuilder could not connect to all FLPs, terminating");
+      if (failOnError) {
+        throw std::runtime_error("TfBuilder could not connect to all FLPs, terminating");
+      }
     }
 
     // only continue when all connections are established