[O2-2559] Avoid out of rage access when smaps contains unexpected data (#267)

awegrzyn · web-flow · commit 0a821559cbcd · 2021-10-17T19:33:09.000+02:00
* [O2-2559] Avoid out of rage access when smaps contains unexpected data

* Bump CMake
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -31,7 +31,7 @@ endif()
 
 # Define project
 project(Monitoring
-  VERSION 3.8.10
+  VERSION 3.8.11
   DESCRIPTION "O2 Monitoring library"
   LANGUAGES CXX
 )
diff --git a/src/ProcessMonitor.cxx b/src/ProcessMonitor.cxx
@@ -142,7 +142,7 @@ double ProcessMonitor::splitStatusLineAndRetriveValue(const std::string& line) c
   std::istringstream iss(line);
   std::vector<std::string> tokens{std::istream_iterator<std::string>{iss},
                                   std::istream_iterator<std::string>{}};
-  return std::stod(tokens[1]);
+  return tokens.size() < 2 ? -1.0 : std::stod(tokens.at(1));
 }
 
 std::vector<Metric> ProcessMonitor::getPerformanceMetrics()

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ endif()`
`31`	`31`
`32`	`32`	`# Define project`
`33`	`33`	`project(Monitoring`
`34`		`- VERSION 3.8.10`
	`34`	`+ VERSION 3.8.11`
`35`	`35`	`DESCRIPTION "O2 Monitoring library"`
`36`	`36`	`LANGUAGES CXX`
`37`	`37`	`)`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ double ProcessMonitor::splitStatusLineAndRetriveValue(const std::string& line) c`
`142`	`142`	`std::istringstream iss(line);`
`143`	`143`	`std::vector<std::string> tokens{std::istream_iterator<std::string>{iss},`
`144`	`144`	`std::istream_iterator<std::string>{}};`
`145`		`- return std::stod(tokens[1]);`
	`145`	`+ return tokens.size() < 2 ? -1.0 : std::stod(tokens.at(1));`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`std::vector<Metric> ProcessMonitor::getPerformanceMetrics()`