[OMON-441] Do log each sending error (#237)

Author: awegrzyn

CMakeLists.txt

@@ -132,6 +132,7 @@ target_link_libraries(Monitoring
     Boost::boost
   PRIVATE
     Boost::system
+    Boost::filesystem
     pthread
     $<$<BOOL:${ApMon_FOUND}>:ApMon::ApMon>
     $<$<BOOL:${RdKafka_FOUND}>:RdKafka::rdkafka++>

src/MonLogger.h

@@ -42,7 +42,7 @@ class MonLogger
   template <typename T>
   MonLogger& operator<<(const T& log)
   {
-    if (MonLogger::globalSeverity >= severity) {
+    if (MonLogger::LogSeverity >= severity) {
       mStream << log;
     }
     return *this;
@@ -68,7 +68,7 @@ class MonLogger
   }
 
   /// Currently set severity
-  const Severity globalSeverity = Severity::Info;
+  const Severity LogSeverity = Severity::Info;
 
  private:
   /// Instance severity

src/Transports/HTTP.cxx

@@ -31,7 +31,7 @@ HTTP::HTTP(const std::string& url)
   FILE *devnull = fopen("/dev/null", "w+");
   curl_easy_setopt(mCurl, CURLOPT_WRITEDATA, devnull);
 
-  MonLogger::Get() << "HTTP transport initialized (" << url << ")" << MonLogger::End();
+  MonLogger::Get(Severity::Info) << "HTTP transport initialized (" << url << ")" << MonLogger::End();
 }
 
 HTTP::~HTTP()
@@ -56,10 +56,10 @@ void HTTP::send(std::string&& post)
   response = curl_easy_perform(mCurl);
   curl_easy_getinfo(mCurl, CURLINFO_RESPONSE_CODE, &responseCode);
   if (response != CURLE_OK) {
-    MonLogger::Get(Severity::Warn) << "HTTP Tranport " << curl_easy_strerror(response) << MonLogger::End();
+    MonLogger::Get() << "HTTP Tranport " << curl_easy_strerror(response) << MonLogger::End();
   }
   if (responseCode < 200 || responseCode > 206) {
-    MonLogger::Get(Severity::Warn) << "HTTP Transport: Response code : " << std::to_string(responseCode) << MonLogger::End();
+    MonLogger::Get() << "HTTP Transport: Response code : " << std::to_string(responseCode) << MonLogger::End();
   }
 }
 

src/Transports/Kafka.cxx

@@ -39,10 +39,10 @@ Kafka::Kafka(const std::string& host, unsigned int port, const std::string& topi
 
   producer = RdKafka::Producer::create(conf, errstr);
   if (!producer) {
-    throw std::runtime_error("Failed to create Kafka producer: " + errstr);
+    MonLogger::Get(Severity::Error) << "Coult not initialize Kafka transport" << MonLogger::End();
   }
 
-  MonLogger::Get() << "Kafka transport initialized (" << host << ":" << port << "/" << mTopic << ")" << MonLogger::End();
+  MonLogger::Get(Severity::Info) << "Kafka transport initialized (" << host << ":" << port << "/" << mTopic << ")" << MonLogger::End();
 }
 
 Kafka::~Kafka()

src/Transports/TCP.cxx

@@ -43,14 +43,15 @@ TCP::TCP(const std::string& hostname, int port) : mSocket(mIoService)
   if (error) {
     throw MonitoringException("TCP connection", error.message());
   }
+  MonLogger::Get(Severity::Info) << "TCP transport initialized (" << hostname << ":" << port << ")" << MonLogger::End();
 }
 
 void TCP::send(std::string&& message)
 {
   try {
     mSocket.send(boost::asio::buffer(message));
   } catch (const boost::system::system_error& e) {
-    MonLogger::Get(Severity::Error) << "TCP / " << e.what() << MonLogger::End();
+    MonLogger::Get() << "TCP / " << e.what() << MonLogger::End();
   }
 }
 

src/Transports/UDP.cxx

@@ -32,7 +32,7 @@ UDP::UDP(const std::string& hostname, int port) : mSocket(mIoService, boost::asi
   boost::asio::ip::udp::resolver::query query(boost::asio::ip::udp::v4(), hostname, std::to_string(port));
   boost::asio::ip::udp::resolver::iterator resolverInerator = resolver.resolve(query);
   mEndpoint = *resolverInerator;
-  MonLogger::Get() << "UDP transport initialized (" << hostname << ":" << port << ")" << MonLogger::End();
+  MonLogger::Get(Severity::Info) << "UDP transport initialized (" << hostname << ":" << port << ")" << MonLogger::End();
 }
 
 void UDP::send(std::string&& message)

src/Transports/Unix.cxx

@@ -15,6 +15,7 @@
 
 #include "Unix.h"
 #include <string>
+#include <boost/filesystem.hpp>
 #include "../MonLogger.h"
 
 namespace o2
@@ -28,16 +29,20 @@ namespace transports
 #if defined(BOOST_ASIO_HAS_LOCAL_SOCKETS)
 Unix::Unix(const std::string& socketPath) : mSocket(mIoService), mEndpoint(socketPath)
 {
-  mSocket.open();
-  MonLogger::Get() << "Unix socket transport initialized (" << socketPath << ")" << MonLogger::End();
+  if (!boost::filesystem::exists(socketPath)) {
+    MonLogger::Get(Severity::Error) << "Unix sockes path is invalid: " << socketPath << MonLogger::End();
+  } else {
+    mSocket.open();
+    MonLogger::Get(Severity::Info) << "Unix socket transport initialized (" << socketPath << ")" << MonLogger::End();
+  }
 }
 
 void Unix::send(std::string&& message)
 {
   try {
     mSocket.send_to(boost::asio::buffer(message, message.size()), mEndpoint);
   } catch (const boost::system::system_error& e) {
-    MonLogger::Get(Severity::Error) << "Unix socket / " << e.what() << MonLogger::End();
+    MonLogger::Get() << "Unix socket / " << e.what() << MonLogger::End();
   }
 }
 #endif // defined(BOOST_ASIO_HAS_LOCAL_SOCKETS)