Add tests to verify that const char* can be passed as metric name (#104)

Author: awegrzyn

test/testMetric.cxx

@@ -10,20 +10,27 @@ namespace o2 {
 namespace monitoring {
 namespace Test {
 
+using namespace o2::monitoring;
+
 BOOST_AUTO_TEST_CASE(retrieveOtherParams)
 {
   int value = 10;
-  std::string name("metric name");
-  o2::monitoring::Metric metricInstance(value,  name);
+  Metric metricInstance(value,  "metric name");
 
   BOOST_CHECK_EQUAL(metricInstance.getName(), "metric name");
 }
 
+BOOST_AUTO_TEST_CASE(constCharName)
+{
+  const char* name = "a name";
+  Metric metricInstance(10,  name);
+  BOOST_CHECK_EQUAL(metricInstance.getName(), "a name");
+}
 
 BOOST_AUTO_TEST_CASE(retrieveInt) {
   int value = 10;
   std::string name("metric name");
-  o2::monitoring::Metric metricInstance(value,  name );
+  Metric metricInstance(value,  name );
 
   BOOST_CHECK_EQUAL(boost::get<int>(metricInstance.getValue()), 10);
   BOOST_CHECK_EQUAL(metricInstance.getType(), 0);
@@ -32,7 +39,7 @@ BOOST_AUTO_TEST_CASE(retrieveInt) {
 BOOST_AUTO_TEST_CASE(retrieveDouble) {
   double value = 1.11;
   std::string name("metric name");
-  o2::monitoring::Metric metricInstance(value,  name );
+  Metric metricInstance(value,  name );
 
   BOOST_CHECK_EQUAL(boost::get<double>(metricInstance.getValue()), 1.11);
   BOOST_CHECK_EQUAL(metricInstance.getType(), 2);
@@ -42,7 +49,7 @@ BOOST_AUTO_TEST_CASE(retrieveString)
 {
   std::string value = "testString";
   std::string name("metric name");
-  o2::monitoring::Metric metricInstance(value,  name );
+  Metric metricInstance(value,  name );
 
   BOOST_CHECK_EQUAL(boost::get<std::string>(metricInstance.getValue()), "testString");
   BOOST_CHECK_EQUAL(metricInstance.getType(), 1);
@@ -52,7 +59,7 @@ BOOST_AUTO_TEST_CASE(retrieveUnsignedLongLong)
 {
   uint64_t value = 10000000000000LL;
   std::string name("metric name");
-  o2::monitoring::Metric metricInstance(value,  name );
+  Metric metricInstance(value,  name );
 
   BOOST_CHECK_EQUAL(boost::get<uint64_t>(metricInstance.getValue()), 10000000000000LL);
   BOOST_CHECK_EQUAL(metricInstance.getType(), 3);
@@ -63,12 +70,12 @@ bool is_critical(const boost::bad_get&) { return true; }
 BOOST_AUTO_TEST_CASE(retrieveWrongType) {
   double value = 1.11;
   std::string name("metric name");
-  o2::monitoring::Metric metricInstance(value,  name );
+  Metric metricInstance(value,  name );
   BOOST_CHECK_EXCEPTION(boost::get<std::string>(metricInstance.getValue()), boost::bad_get, is_critical);
 }
 
 BOOST_AUTO_TEST_CASE(tags) {
-  o2::monitoring::Metric metric = Metric{10, "myMetric"}.addTags({o2::monitoring::tags::Detector::TPC, o2::monitoring::tags::Detector::TRD});
+  Metric metric = Metric{10, "myMetric"}.addTags({o2::monitoring::tags::Detector::TPC, o2::monitoring::tags::Detector::TRD});
   auto tags = metric.getTags();
   int sum = 0;
   for (auto const& tag: tags) {
@@ -78,8 +85,8 @@ BOOST_AUTO_TEST_CASE(tags) {
 }
 
 BOOST_AUTO_TEST_CASE(customCopyConstructor) {
-  o2::monitoring::Metric metric = Metric{10, "myMetric"}.addTags({o2::monitoring::tags::Detector::TPC, o2::monitoring::tags::Detector::TRD});
-  o2::monitoring::Metric assigned{1, "assingedMetric"};
+  Metric metric = Metric{10, "myMetric"}.addTags({o2::monitoring::tags::Detector::TPC, o2::monitoring::tags::Detector::TRD});
+  Metric assigned{1, "assingedMetric"};
   auto copied = metric;
   assigned = metric;
   BOOST_CHECK_EQUAL(boost::get<int>(copied.getValue()), 10);