Skip to content

Commit 2f917a2

Browse files
authored
[OMON-661] Remove division by 0 log message (#319)
1 parent 2daddd2 commit 2f917a2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ endif()
3131

3232
# Define project
3333
project(Monitoring
34-
VERSION 3.17.3
34+
VERSION 3.17.4
3535
DESCRIPTION "O2 Monitoring library"
3636
LANGUAGES CXX
3737
)

src/DerivedMetrics.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ bool DerivedMetrics::process(Metric& metric, DerivedMetricMode mode)
8080
int timestampCount = timestampDifference.count();
8181
// disallow dividing by 0
8282
if (timestampCount == 0) {
83-
throw MonitoringException("DerivedMetrics", "Division by 0 when calculating rate for: " + metric.getName() + "/" + metric.getFirstValue().first);
83+
//throw MonitoringException("DerivedMetrics", "Division by 0 when calculating rate for: " + metric.getName() + "/" + metric.getFirstValue().first);
8484
}
8585

8686
auto current = metric.getFirstValue().second;

test/testDerived.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,15 +171,15 @@ bool exceptionCheck(const MonitoringException& e)
171171
return false;
172172
}
173173

174-
BOOST_AUTO_TEST_CASE(divisionByZero)
174+
/*BOOST_AUTO_TEST_CASE(divisionByZero)
175175
{
176176
std::string name("test");
177177
o2::monitoring::DerivedMetrics derivedHandler;
178178
o2::monitoring::Metric metric(10, name);
179179
180180
derivedHandler.process(metric, DerivedMetricMode::RATE);
181181
BOOST_CHECK_EXCEPTION(derivedHandler.process(metric, DerivedMetricMode::RATE), MonitoringException, exceptionCheck);
182-
}
182+
}*/
183183

184184
BOOST_AUTO_TEST_CASE(derivedIncrementInt)
185185
{

0 commit comments

Comments
 (0)