Fix codacy issues (#118)

Author: awegrzyn

README.md

@@ -2,6 +2,7 @@
 [![travis-ci](https://api.travis-ci.org/AliceO2Group/Monitoring.svg?branch=master)](https://travis-ci.org/AliceO2Group/Monitoring)
 [![aliBuild](https://img.shields.io/badge/aliBuild-dashboard-lightgrey.svg)](https://alisw.cern.ch/dashboard/d/000000001/main-dashboard?orgId=1&var-storagename=All&var-reponame=All&var-checkname=build%2FMonitoring%2Fo2-dataflow%2F0&var-upthreshold=30m&var-minuptime=30)
 [![codecov](https://codecov.io/gh/AliceO2Group/Monitoring/branch/dev/graph/badge.svg)](https://codecov.io/gh/AliceO2Group/Monitoring/branch/dev)
+[![Codacy Badge](https://api.codacy.com/project/badge/Grade/3816cb37f02e4801ac62df080d5b6c9c)](https://www.codacy.com/app/awegrzyn/Monitoring?utm_source=github.com&utm_medium=referral&utm_content=AliceO2Group/Monitoring&utm_campaign=Badge_Grade)
 [![JIRA](https://img.shields.io/badge/JIRA-issues-blue.svg)](https://alice.its.cern.ch/jira/projects/OMON)
 [![doxygen](https://img.shields.io/badge/doxygen-documentation-blue.svg)](https://aliceo2group.github.io/Monitoring/)
 
@@ -20,14 +21,13 @@ Monitoring module allows to inject user defined metrics and monitor the process
 <strong>[Click here if you don't have aliBuild installed](https://alice-doc.github.io/alice-analysis-tutorial/building/)</strong>
 <br>
 
-+ Compile `Monitoring` and its dependecies via `aliBuild`
-```
-aliBuild init Monitoring@master
-aliBuild build Monitoring --defaults o2-daq
+  + Compile `Monitoring` and its dependecies via `aliBuild`
+```bash
+aliBuild build Monitoring --defaults o2-dataflow
 ```
 
-+ Load the enviroment for Monitoring (in the `alice` directory)
-```
+  + Load the enviroment for Monitoring (in the `alice` directory)
+```bash
 alienv load Monitoring/latest
 ```
 
@@ -37,16 +37,14 @@ In case of an issue with `aliBuild` refer to [the official instructions](https:/
 Manual installation of the O<sup>2</sup> Monitoring module.
 
 #### Requirements
-+ C++ compiler with C++17 support, eg.:
-  + `gcc-c++` package from `devtoolset-7` on CentOS 7
-  + `clang++` on Mac OS
-+ Boost >= 1.56
-+ libcurl
-+ [ApMon](http://monalisa.caltech.edu/monalisa__Download__ApMon.html) (optional)
+  + C++ compiler with C++17 support
+  + Boost >= 1.56
+  + libcurl
+  + [ApMon](http://monalisa.caltech.edu/monalisa__Download__ApMon.html) (optional)
 
 #### Monitoring module compilation
 
-```
+```bash
 git clone https://github.com/AliceO2Group/Monitoring.git
 cd Monitoring; mkdir build; cd build
 cmake .. -DCMAKE_INSTALL_PREFIX=<installdir>
@@ -67,14 +65,14 @@ std::unique_ptr<Monitoring> monitoring = MonitoringFactory::Get("backend[-protoc
 
 See table below to find out how to create `URI` for each backend:
 
-| Backend name | Transport | URI backend[-protocol] | URI query  | Default verbosity |
-| ------------ |:---------:|:----------------------:|:----------:| -----------------:|
-| InfluxDB     | HTTP      | `influxdb-http`        | `?db=<db>` | `info`            |
-| InfluxDB     | UDP       | `influxdb-udp`         | -          | `info`            |
-| InfluxDB     | Unix datagram | `influxdb-unix`    | -          | `info`            |
-| ApMon        | UDP       | `apmon`                | -          | `info`            |
-| StdOut       | -         | `stdout`, `infologger` | -          | `debug`           |
-| Flume        | UDP       | `flume`                | -          | `info`            |
+| Backend name | Transport   | URI backend[-protocol] | URI query  | Default verbosity |
+| ------------ |:-----------:|:----------------------:|:----------:| -----------------:|
+| InfluxDB     | HTTP        | `influxdb-http`        | `?db=<db>` | `info`            |
+| InfluxDB     | UDP         | `influxdb-udp`         | -          | `info`            |
+| InfluxDB     | Unix socket | `influxdb-unix`        | -          | `info`            |
+| ApMon        | UDP         | `apmon`                | -          | `info`            |
+| StdOut       | -           | `stdout`, `infologger` | -          | `debug`           |
+| Flume        | UDP         | `flume`                | -          | `info`            |
 
 ##### StdCout output format
 ```
@@ -84,13 +82,13 @@ See table below to find out how to create `URI` for each backend:
 ### Metrics
 A metric consist of 5 parameters: name, value, timestamp, verbosity and tags.
 
-| Parameter name | Type                                          | Required | Default        |
-| -------------- |:---------------------------------------------:|:--------:| --------------:|
-| name           | string                                        | yes      | -              |
-| value          | int / double / string / uint64_t              | yes      | -              |
-| timestamp      | chrono::time_point&lt;std::chrono::system_clock&gt; | no | current timestamp |
-| verbosity      | Debug / Info / Prod                           | no       | Info           |
-| tags           | vector<unsigned int>                          | no       | -              |
+| Parameter name | Type                             | Required | Default      |
+| -------------- |:--------------------------------:|:--------:| ------------:|
+| name           | string                           | yes      | -            |
+| value          | int / double / string / uint64_t | yes      | -            |
+| timestamp      | time_point&lt;system_clock&gt;   | no       | current time |
+| verbosity      | Debug / Info / Prod              | no       | Info         |
+| tags           | vector<unsigned int>             | no       | -            |
 
 A metric can be constructed by providing required parameters (value and name):
 ```cpp
@@ -106,7 +104,6 @@ Metric{10, "name", Verbosity::Prod}
 
 Metrics need to match backends verbosity in order to be sent, eg. backend with `/info` verbosity will accept `Info` and `Prod` metrics only.
 
-
 #### Tags
 Each metric can be tagged with any number of [predefined tags](include/Monitoring/Tags.h).
 In order to do so use `addTag(tags::Key, tags::Value)` or `addTag(tags::Key, unsigned short)` methods. The latter method allows assigning numeric value to a tag.
@@ -153,18 +150,18 @@ See how it works in the example: [examples/10-Buffering.cxx](examples/10-Bufferi
 
 ### Calculating derived metrics
 The module can calculate derived metrics. To do so, use optional `DerivedMetricMode mode` parameter of `send` method:
-+ `DerivedMetricMode::NONE` - no action,
-+ `DerivedMetricMode::RATE` - rate between two following metrics,
-+ `DerivedMetricMode::AVERAGE` - average value of all metrics stored in cache.
+  + `DerivedMetricMode::NONE` - no action,
+  + `DerivedMetricMode::RATE` - rate between two following metrics,
+  + `DerivedMetricMode::AVERAGE` - average value of all metrics stored in cache.
 
 Derived metrics are generated each time as new value is passed to the module. Their names are suffixed with derived mode name.
 
 See how it works in the example: [examples/4-RateDerivedMetric.cxx](examples/4-RateDerivedMetric.cxx).
 
 ### Global tags
 Glabal tags are tags that are added to each metric. The following tags are set to global by library itself:
-- `hostname`
-- `name` - process name
+  + `hostname`
+  + `name` - process name
 
 You can add your own global tag by calling `addGlobalTag(std::string_view key, std::string_view value)` or `addGlobalTag(tags::Key, tags::Value)`.
 
@@ -173,9 +170,9 @@ You can add your own global tag by calling `addGlobalTag(std::string_view key, s
 enableProcessMonitoring([interval in seconds]);
 ```
 The following metrics are generated every interval:
-+ **cpuUsedPercentage** - percentage of a core usage over time interval
-+ **involuntaryContextSwitches** - involuntary context switches over time interval
-+ **memoryUsagePercentage** - ratio of the process's resident set size  to the physical memory on the machine, expressed as a percentage (Linux only)
+  + **cpuUsedPercentage** - percentage of a core usage over time interval
+  + **involuntaryContextSwitches** - involuntary context switches over time interval
+  + **memoryUsagePercentage** - ratio of the process's resident set size  to the physical memory on the machine, expressed as a percentage (Linux only)
 
 ### Automatic metric updates
 Sometimes it's necessary to provide value every exact interval of time (even though value does not change). This can be done using `AutoPushMetric`.
@@ -188,8 +185,8 @@ See how it works in the example: [examples/11-AutoUpdate.cxx](examples/11-AutoUp
 ## System monitoring, server-side backends installation and configuration
 This guide explains manual installation. For `ansible` deployment see [AliceO2Group/system-configuration](https://gitlab.cern.ch/AliceO2Group/system-configuration/tree/master/ansible) gitlab repo.
 
- + [Collectd](doc/collectd.md)
- + [Flume](doc/flume.md)
- + [InfluxDB](doc/influxdb.md)
- + [Grafana](doc/grafana.md)
- + [MonALISA](http://monalisa.caltech.edu/monalisa__Documentation__Service_Installation_Guide.html) (external link)
++ [Collectd](doc/collectd.md)
++ [Flume](doc/flume.md)
++ [InfluxDB](doc/influxdb.md)
++ [Grafana](doc/grafana.md)
++ [MonALISA](http://monalisa.caltech.edu/monalisa__Documentation__Service_Installation_Guide.html) (external link)

src/Backends/Flume.cxx

@@ -18,9 +18,9 @@ namespace monitoring
 namespace backends
 {
 
-Flume::Flume(const std::string& host, unsigned int port)
+Flume::Flume(const std::string& host, unsigned int port) :
+  mTransport(std::make_unique<transports::UDP>(host, port))
 {
-  mTransport = std::make_unique<transports::UDP>(host, port);
   MonLogger::Get() << "Flume/UDP backend initialized"
                    << " ("<< host << ":" << port << ")" << MonLogger::End();
 }

src/Backends/InfluxDB.cxx

@@ -20,25 +20,25 @@ namespace monitoring
 namespace backends
 {
 
-InfluxDB::InfluxDB(const std::string& host, unsigned int port)
+InfluxDB::InfluxDB(const std::string& host, unsigned int port) :
+  mTransport(std::make_unique<transports::UDP>(host, port))
 {
-  transport = std::make_unique<transports::UDP>(host, port);
   MonLogger::Get() << "InfluxDB/UDP backend initialized"
                    << " ("<< host << ":" << port << ")" << MonLogger::End();
 }
 
 InfluxDB::InfluxDB(const std::string& host, unsigned int port, const std::string& search)
 {
-  transport = std::make_unique<transports::HTTP>(
+  mTransport = std::make_unique<transports::HTTP>(
     "http://" + host + ":" + std::to_string(port) + "/write?" + search
   );
   MonLogger::Get() << "InfluxDB/HTTP backend initialized" << " (" << "http://" << host
                    << ":" <<  std::to_string(port) << "/write?" << search << ")" << MonLogger::End();
 }
 
-InfluxDB::InfluxDB(const std::string& socketPath)
+InfluxDB::InfluxDB(const std::string& socketPath) :
+  mTransport(std::make_unique<transports::Unix>(socketPath))
 {
-  transport = std::make_unique<transports::Unix>(socketPath);
   MonLogger::Get() << "InfluxDB/Unix backend initialized (" << socketPath << ")" << MonLogger::End();
 }
 
@@ -71,7 +71,7 @@ void InfluxDB::sendMultiple(std::string measurement, std::vector<Metric>&& metri
   convert << " " <<  convertTimestamp(metrics.back().getTimestamp());
 
   try {
-    transport->send(convert.str());
+    mTransport->send(convert.str());
   } catch (MonitoringException&) {
   }
 }
@@ -84,7 +84,7 @@ void InfluxDB::send(std::vector<Metric>&& metrics) {
   }
 
   try {
-    transport->send(std::move(influxMetrics));
+    mTransport->send(std::move(influxMetrics));
   } catch (MonitoringException&) {
   }
 
@@ -93,7 +93,7 @@ void InfluxDB::send(std::vector<Metric>&& metrics) {
 void InfluxDB::send(const Metric& metric)
 {
   try {
-    transport->send(toInfluxLineProtocol(metric));
+    mTransport->send(toInfluxLineProtocol(metric));
   } catch (MonitoringException&) {
   }
 }

src/Backends/InfluxDB.h

@@ -67,7 +67,7 @@ class InfluxDB final : public Backend
     void addGlobalTag(std::string_view name, std::string_view value) override;
 
   private:
-    std::unique_ptr<transports::TransportInterface> transport; ///< InfluxDB transport
+    std::unique_ptr<transports::TransportInterface> mTransport; ///< InfluxDB transport
     std::string tagSet; ///< Global tagset (common for each metric)
 
     /// Escapes " ", "," and "=" characters

src/Transports/TCP.cxx

@@ -45,20 +45,6 @@ void TCP::send(std::string&& message)
   }
 }
 
-void TCP::read() {
-  for (;;) {
-    boost::system::error_code error;
-    boost::array<char, 128> buf;
-    size_t len = mSocket.read_some(boost::asio::buffer(buf), error);
-    if (error == boost::asio::error::eof) {
-      break;
-    } else {
-      return;
-    }
-    std::cout.write(buf.data(), len);
-  }
-}
-
 } // namespace transports
 } // namespace monitoring
 } // namespace o2

src/Transports/TCP.h

@@ -39,9 +39,6 @@ class TCP : public TransportInterface
     /// \param message   r-value string formated
     void send(std::string&& message) override;
 
-    /// Dummy read method - Forwards read out buffer to cout
-    void read();
-
   private:
     /// Boost Asio I/O functionality
     boost::asio::io_service mIoService;