Do not throw when sending a value fails (#83)

Author: awegrzyn

include/Monitoring/MonitoringFactory.h

@@ -24,10 +24,12 @@ class MonitoringFactory
 
     /// Provides single instance on Monitoring Monitoring (singleton)
     /// \return              renerence to Monitoring instance
-    static std::unique_ptr<Monitoring> Get(std::string urlsString);
+    /// \throw MonitoringException when backend initialisation failed
+    static std::unique_ptr<Monitoring> Get(std::string urlsString) noexcept(false);
 
     /// Provides a Monitoring backend based on the URL
     /// \return		monitoring backend
+    /// \throw MonitoringException when backend initialisation failed
     static std::unique_ptr<Backend> GetBackend(std::string& url);
   private:
     /// Private constructor disallows to create instance of Factory

src/DerivedMetrics.cxx

@@ -13,7 +13,6 @@
 #include <memory>
 #include <string>
 #include <vector>
-#include "MonLogger.h"
 #include "VariantVisitorRate.h"
 #include "VariantVisitorAdd.h"
 

src/Monitoring.cxx

@@ -4,6 +4,7 @@
 ///
 
 #include "Monitoring/Monitoring.h"
+#include "Exceptions/MonitoringException.h"
 
 #include <boost/lexical_cast.hpp>
 #include <chrono>
@@ -198,14 +199,17 @@ void Monitoring::pushToBackends(Metric&& metric)
 
 void Monitoring::send(Metric&& metric, DerivedMetricMode mode)
 {
-  if (mode == DerivedMetricMode::RATE) {
-    pushToBackends(mDerivedHandler->rate(metric));
-  }
+  try {
+    if (mode == DerivedMetricMode::RATE) {
+      pushToBackends(mDerivedHandler->rate(metric));
+    }
 
-  if (mode == DerivedMetricMode::INCREMENT) {
-    pushToBackends(mDerivedHandler->increment(metric));
+    if (mode == DerivedMetricMode::INCREMENT) {
+      pushToBackends(mDerivedHandler->increment(metric));
+    }
+  } catch(MonitoringException& e) {
+    MonLogger::Get() << "[WARN] " << e.what() << MonLogger::End();
   }
-
   pushToBackends(std::move(metric));
 }
 

src/Transports/HTTP.cxx

@@ -4,6 +4,7 @@
 ///
 
 #include "HTTP.h"
+#include "../MonLogger.h"
 #include "../Exceptions/MonitoringException.h"
 #include <boost/algorithm/string.hpp>
 #include <iostream>
@@ -57,10 +58,10 @@ void HTTP::send(std::string&& post)
   response = curl_easy_perform(curlHandle.get());
   curl_easy_getinfo(curlHandle.get(), CURLINFO_RESPONSE_CODE, &responseCode);
   if (response != CURLE_OK) {
-    throw MonitoringException("HTTP Tranposrt", curl_easy_strerror(response));
+    MonLogger::Get() << "HTTP Tranport " << curl_easy_strerror(response) << MonLogger::End();
   }
   if (responseCode < 200 || responseCode > 206) {
-    throw MonitoringException("HTTP Transport", "Response code : " + std::to_string(responseCode));
+    MonLogger::Get() << "HTTP Transport: Response code : " << std::to_string(responseCode) << MonLogger::End();
   }
 }
 

src/Transports/TCP.cxx

@@ -7,6 +7,7 @@
 #include <string>
 #include <iostream>
 #include "Exceptions/MonitoringException.h"
+#include "../MonLogger.h"
 
 namespace o2
 {
@@ -40,7 +41,7 @@ void TCP::send(std::string&& message)
   try {
     mSocket.send(boost::asio::buffer(message));
   } catch(const boost::system::system_error& e) {
-    throw MonitoringException("TCP send", e.what());
+    MonLogger::Get() << "TCP send: " << e.what() << MonLogger::End();
   }
 }