Skip to content

Commit 7ce16aa

Browse files
authored
Fix: by default get all PM metrics (#302)
1 parent a9c37bd commit 7ce16aa

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ endif()
3131

3232
# Define project
3333
project(Monitoring
34-
VERSION 3.13.1
34+
VERSION 3.13.2
3535
DESCRIPTION "O2 Monitoring library"
3636
LANGUAGES CXX
3737
)

include/Monitoring/Monitoring.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class Monitoring
7171
/// Enables process monitoring
7272
/// \param interval refresh interval
7373
/// \param enabledMeasurements vector of monitor measurements, eg. PmMeasurement::Cpu
74-
void enableProcessMonitoring(const unsigned int interval = 5, std::vector<PmMeasurement> enabledMeasurements = {PmMeasurement::Cpu, PmMeasurement::Mem});
74+
void enableProcessMonitoring(const unsigned int interval = 5, std::vector<PmMeasurement> enabledMeasurements = {PmMeasurement::Cpu, PmMeasurement::Mem, PmMeasurement::Smaps});
7575

7676
/// Flushes metric buffer (this can also happen when buffer is full)
7777
void flushBuffer();

test/testProcessMonitor.cxx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ BOOST_AUTO_TEST_CASE(monitorProcessDefaultCount)
5555
countMetrics++;
5656
}
5757
// On linux 11 (without Smaps) and macOS 6
58-
BOOST_CHECK(countMetrics == 11 || countMetrics == 6);
58+
BOOST_CHECK(countMetrics == 14 || countMetrics == 6);
5959
}
6060

6161

@@ -83,13 +83,13 @@ BOOST_AUTO_TEST_CASE(monitorProcessCpuOnly)
8383

8484
BOOST_AUTO_TEST_CASE(monitorProcessAll)
8585
{
86-
std::array<std::string, 14> names = {"memoryUsagePercentage", "virtualMemorySize", "residentSetSize",
86+
std::array<std::string, 11> names = {"memoryUsagePercentage", "virtualMemorySize", "residentSetSize",
8787
"cpuUsedPercentage", "involuntaryContextSwitches", "voluntaryContextSwitches", "cpuUsedAbsolute",
8888
"averageResidentSetSize", "averageVirtualMemorySize", "averageCpuUsedPercentage",
89-
"cpuTimeConsumedByProcess", "proportionalSetSize", "memoryPrivateClean", "memoryPrivateDirty"};
89+
"cpuTimeConsumedByProcess"};
9090
{
9191
auto monitoring = o2::monitoring::MonitoringFactory::Get("influxdb-stdout://");
92-
monitoring->enableProcessMonitoring(1, {PmMeasurement::Cpu, PmMeasurement::Smaps, PmMeasurement::Mem});
92+
monitoring->enableProcessMonitoring(1, {PmMeasurement::Cpu, PmMeasurement::Mem});
9393
enableRedirect();
9494
std::this_thread::sleep_for(std::chrono::milliseconds(200));
9595
}
@@ -102,7 +102,7 @@ BOOST_AUTO_TEST_CASE(monitorProcessAll)
102102
countMetrics++;
103103
}
104104
// On linux 14 and macOS 6
105-
BOOST_CHECK(countMetrics == 14 || countMetrics == 6);
105+
BOOST_CHECK(countMetrics == 11 || countMetrics == 6);
106106
}
107107

108108
BOOST_AUTO_TEST_CASE(monitorProcessMetricName)

0 commit comments

Comments
 (0)