Do not return Metric name as a string (#102)

Author: awegrzyn

include/Monitoring/Metric.h

@@ -54,10 +54,7 @@ class Metric
 
     /// Name getter
     /// \return	metric name
-    std::string getName() const;
-
-    /// Const name getter
-    const std::string& getConstName() const;
+    const std::string& getName() const;
 
     /// Timestamp getter
     /// \return 	metric timestamp

src/Backends/InfluxDB.cxx

@@ -93,7 +93,7 @@ void InfluxDB::send(const Metric& metric)
 
 std::string InfluxDB::toInfluxLineProtocol(const Metric& metric) {
   std::stringstream convert;
-  std::string name = metric.getConstName();
+  std::string name = metric.getName();
   escape(name);
   convert << name << "," << tagSet;
 

src/Backends/StdOut.cxx

@@ -54,15 +54,15 @@ void StdOut::sendMultiple(std::string measurement, std::vector<Metric>&& metrics
     metricTags += tags::TAG_ARRAY[tagIndex].second;
   } 
   for (auto& metric : metrics) {
-    mStream << "[METRIC] " << measurement << '/' << metric.getConstName() << ',' << metric.getType() << ' '
+    mStream << "[METRIC] " << measurement << '/' << metric.getName() << ',' << metric.getType() << ' '
       << metric.getValue() << ' ' << convertTimestamp(metric.getTimestamp()) << ' ' << tagString
       << metricTags << '\n';
   }
 }
 
 void StdOut::send(const Metric& metric)
 {
-  mStream << "[METRIC] " << metric.getConstName() << ',' << metric.getType() << " " << metric.getValue()
+  mStream << "[METRIC] " << metric.getName() << ',' << metric.getType() << " " << metric.getValue()
           << ' ' << convertTimestamp(metric.getTimestamp()) << ' ' << tagString;
 
   for (const auto& tagIndex : metric.getTags()) {

src/Metric.cxx

@@ -25,12 +25,7 @@ int Metric::getType() const
   return mValue.which();
 }
 
-std::string Metric::getName() const
-{
-  return mName;
-}
-
-const std::string& Metric::getConstName() const
+const std::string& Metric::getName() const
 {
   return mName;
 }