Skip to content

Commit e87efb7

Browse files
authored
Fix warning when testing flume (#140)
1 parent c6c9661 commit e87efb7

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/Backends/Flume.h

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,18 +70,22 @@ class Flume final : public Backend
7070
/// \param name tag name
7171
/// \param value tag value
7272
void addGlobalTag(std::string_view name, std::string_view value) override;
73-
73+
74+
/// Serializes metric object to JSON
75+
/// \param metric
76+
/// \return JSON serializes metric
77+
std::string metricToJson(const Metric& metric);
7478
private:
7579
/// UDP transport
7680
std::unique_ptr<transports::TransportInterface> mTransport;
7781

7882
/// Flume backend global header (for each metric)
7983
boost::property_tree::ptree globalHeader;
8084

81-
/// Serializes metric object to JSON
82-
/// \param metric
85+
/// Serializes mesurement to to JSON
86+
/// \param measurement
87+
/// \param metrics
8388
/// \return JSON serializes metric
84-
std::string metricToJson(const Metric& metric);
8589
std::string metricsToJson(std::string measurement, std::vector<Metric>&& metrics);
8690
};
8791

test/testFlume.cxx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <boost/test/unit_test.hpp>
1616
#include <boost/property_tree/json_parser.hpp>
1717

18-
#define private public // evil hack to test private method
1918
#include "../src/Backends/Flume.h"
2019

2120

0 commit comments

Comments
 (0)