Skip to content

Commit 30eeed2

Browse files
authored
Merge pull request #199 from sy-c/master
v2.5.2
2 parents 5024621 + e810c47 commit 30eeed2

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

doc/configurationParameters.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ The parameters related to 3rd-party libraries are described here for convenience
112112
| equipment-* | saveErrorPagesMax | int | 0 | If set, pages found with data error are saved to disk up to given maximum. |
113113
| equipment-* | saveErrorPagesPath | string | | Path where to save data pages with errors (when feature enabled). |
114114
| equipment-* | stopOnError | int | 0 | If 1, readout will stop automatically on equipment error. |
115-
| equipment-* | TFperiod | int | 256 | Duration of a timeframe, in number of LHC orbits. |
115+
| equipment-* | TFperiod | int | 128 | Duration of a timeframe, in number of LHC orbits. |
116116
| equipment-cruemulator-* | cruBlockSize | int | 8192 | Size of a RDH block. |
117117
| equipment-cruemulator-* | cruId | int | 0 | CRU Id, used for CRU Id field in RDH. |
118118
| equipment-cruemulator-* | dpwId | int | 0 | CRU end-point Id (data path wrapper id), used for DPW Id field in RDH. |

doc/releaseNotes.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,3 +376,7 @@ This file describes the main feature changes for each readout.exe released versi
376376
- Updated configuration parameters:
377377
- added equipment-*.dataPagesLogPath to allow saving to disk summary debug info for all data pages received.
378378
- Fixed spurious "Non-contiguous timeframe IDs" warning: the check was too strict, having some links 1 TF behind is fine.
379+
380+
## v2.5.2 - 13/09/2021
381+
- Updated configuration parameters:
382+
- equipment.TFperiod is now set to 128 by default, instead of 256 previously. This is the duration of a timeframe, in number of LHC orbits.

src/ReadoutEquipment.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ ReadoutEquipment::ReadoutEquipment(ConfigFile& cfg, std::string cfgEntryPoint, b
140140
theLog.log(LogInfoDevel_(3002), "RDH settings: rdhCheckEnabled=%d rdhDumpEnabled=%d rdhDumpErrorEnabled=%d rdhDumpWarningEnabled=%d rdhUseFirstInPageEnabled=%d", cfgRdhCheckEnabled, cfgRdhDumpEnabled, cfgRdhDumpErrorEnabled, cfgRdhDumpWarningEnabled, cfgRdhUseFirstInPageEnabled);
141141

142142
if (!cfgDisableTimeframes) {
143-
// configuration parameter: | equipment-* | TFperiod | int | 256 | Duration of a timeframe, in number of LHC orbits. |
144-
int cfgTFperiod = 256;
143+
// configuration parameter: | equipment-* | TFperiod | int | 128 | Duration of a timeframe, in number of LHC orbits. |
144+
int cfgTFperiod = 128;
145145
cfg.getOptionalValue<int>(cfgEntryPoint + ".TFperiod", cfgTFperiod);
146146
timeframePeriodOrbits = cfgTFperiod;
147147

src/ReadoutEquipment.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ class ReadoutEquipment
144144

145145
//const unsigned int LHCBunches = 3564; // number of bunches in LHC
146146
const unsigned int LHCOrbitRate = 11246; // LHC orbit rate, in Hz. 299792458 / 26659
147-
uint32_t timeframePeriodOrbits = 256; // timeframe interval duration in number of LHC orbits
147+
uint32_t timeframePeriodOrbits = 128; // timeframe interval duration in number of LHC orbits
148148
double timeframeRate = 0; // timeframe rate, when generated internally
149149

150150
// RDH-related configuration parameters

src/ReadoutVersion.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
// granted to it by virtue of its status as an Intergovernmental Organization
1010
// or submit itself to any jurisdiction.
1111

12-
#define READOUT_VERSION "2.5.1"
12+
#define READOUT_VERSION "2.5.2"
1313

src/readoutConfigEditor.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ set configurationParametersDescriptor {
9090
| equipment-* | saveErrorPagesMax | int | 0 | If set, pages found with data error are saved to disk up to given maximum. |
9191
| equipment-* | saveErrorPagesPath | string | | Path where to save data pages with errors (when feature enabled). |
9292
| equipment-* | stopOnError | int | 0 | If 1, readout will stop automatically on equipment error. |
93-
| equipment-* | TFperiod | int | 256 | Duration of a timeframe, in number of LHC orbits. |
93+
| equipment-* | TFperiod | int | 128 | Duration of a timeframe, in number of LHC orbits. |
9494
| equipment-cruemulator-* | cruBlockSize | int | 8192 | Size of a RDH block. |
9595
| equipment-cruemulator-* | cruId | int | 0 | CRU Id, used for CRU Id field in RDH. |
9696
| equipment-cruemulator-* | dpwId | int | 0 | CRU end-point Id (data path wrapper id), used for DPW Id field in RDH. |

0 commit comments

Comments
 (0)