[roc] CLI tools should throw the errors they catch

Author: kostorr

src/CommandLineUtilities/ProgramConfig.cxx

@@ -168,7 +168,7 @@ class ProgramConfig : public Program
         FirmwareChecker().checkFirmwareCompatibility(cardId);
       } catch (const Exception& e) {
         Logger::get() << boost::diagnostic_information(e) << LogErrorOps << endm;
-        return;
+        throw(e);
       }
     }
 
@@ -244,13 +244,15 @@ class ProgramConfig : public Program
         CardConfigurator(params, mOptions.forceConfig);
       } catch (const Exception& e) {
         Logger::get() << boost::diagnostic_information(e) << LogErrorOps << endm;
+        throw(e);
       }
     } else {
       Logger::get() << "Configuring with config uri" << LogDebugOps << endm;
       try {
         CardConfigurator(cardId, mOptions.configUri, mOptions.forceConfig);
       } catch (std::runtime_error& e) {
         Logger::get() << "Error parsing the configuration..." << boost::diagnostic_information(e) << LogErrorOps << endm;
+        throw(e);
       }
     }
     return;

src/CommandLineUtilities/ProgramListCards.cxx

@@ -86,10 +86,9 @@ class ProgramListCards : public Program
         // Check if the firmware is tagged
         firmware = FirmwareChecker().resolveFirmwareTag(firmware);
       } catch (const Exception& e) {
-        if (isVerbose()) {
-          std::cout << "Error parsing card information through BAR\n"
-                    << boost::diagnostic_information(e) << '\n';
-        }
+        std::cerr << "Error parsing card information through BAR\n"
+                  << boost::diagnostic_information(e) << '\n';
+        throw(e);
       }
 
       // Pad the serial with 0s if necessary

src/CommandLineUtilities/ProgramSiuStatus.cxx

@@ -69,8 +69,8 @@ class ProgramSiuStatus : public Program
     try {
       siuStatus = crorc.siuStatus();
     } catch (const Exception& e) {
-      std::cout << diagnostic_information(e) << std::endl;
-      return;
+      std::cerr << diagnostic_information(e) << std::endl;
+      throw(e);
     }
 
     std::stringstream ss;