[crorc] Remove legacy pending DMA relation

Author: kostorr

src/Crorc/CrorcDmaChannel.cxx

@@ -109,29 +109,12 @@ void CrorcDmaChannel::deviceStartDma()
 
   startDataReceiving();
 
-  log("DMA start deferred until enough superpages available", LogInfoDevel);
-
   while (!mReadyQueue.isEmpty()) {
     mReadyQueue.popFront();
   }
   while (!mTransferQueue.isEmpty()) {
     mTransferQueue.popFront();
   }
-  mPendingDmaStart = true;
-}
-
-void CrorcDmaChannel::startPendingDma()
-{
-  if (!mPendingDmaStart) {
-    return;
-  }
-
-  if (mTransferQueue.isEmpty()) { // We should never end up in here
-    log("Insufficient superpages to start pending DMA", LogErrorDevel);
-    return;
-  }
-
-  log("Starting pending DMA", LogInfoDevel);
 
   if (mGeneratorEnabled) {
     log("Starting data generator", LogInfoDevel);
@@ -151,7 +134,6 @@ void CrorcDmaChannel::startPendingDma()
 
   std::this_thread::sleep_for(100ms);
 
-  mPendingDmaStart = false;
   log("DMA started", LogInfoOps);
 }
 
@@ -275,15 +257,6 @@ bool CrorcDmaChannel::isASuperpageAvailable()
 
 void CrorcDmaChannel::fillSuperpages()
 {
-  if (mPendingDmaStart) {
-    if (!mTransferQueue.isEmpty()) {
-      startPendingDma();
-    } else {
-      // Waiting on enough superpages to start DMA...
-      return;
-    }
-  }
-
   // Check for arrivals & handle them
   if (!mIntermediateQueue.isEmpty() && isASuperpageAvailable()) {
 

src/Crorc/CrorcDmaChannel.h

@@ -118,9 +118,6 @@ class CrorcDmaChannel final : public DmaChannelPdaBase
   /// Bus address of Superpage info in DMA buffer
   uintptr_t mSuperpageInfoAddressBus;
 
-  /// Starts pending DMA with given superpage for the initial pages
-  void startPendingDma();
-
   /// BAR used for DMA engine and configuration
   std::shared_ptr<CrorcBar> crorcBar;
 
@@ -136,10 +133,6 @@ class CrorcDmaChannel final : public DmaChannelPdaBase
   /// Address of DMA buffer in userspace
   uintptr_t mDmaBufferUserspace = 0;
 
-  /// Indicates deviceStartDma() was called, but DMA was not actually started yet. We do this because we need a
-  /// superpage to actually start.
-  bool mPendingDmaStart = false;
-
   // These variables are configuration parameters
 
   /// DMA page size