Skip to content

Commit 4c517e9

Browse files
committed
Firmware check only on git hash
1 parent 5cbafa7 commit 4c517e9

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,7 @@ In order to use a CRU the package versions have to adhere to the following table
435435
| v0.14.5 | v3.4.0 | release TBA | v1.0.4+ | v12.0.0 |
436436
| v0.14.5 | v3.5.0 | release TBA | v1.0.4+ | v12.0.0 |
437437
| v0.15.0 | v3.5.1 | release TBA | v1.0.4+ | v12.0.0 |
438+
| | v3.5.2 | release TBA | v1.0.4+ | v12.0.0 |
438439
439440
The _PDA Driver_ entry refers to the `pda-kadapter-dkms-*.rpm` package which is availabe through the [o2-daq-yum](http://alice-daq-yum-o2.web.cern.ch/alice-daq-yum-o2/cc7_64/) repo as an RPM.
440441

src/FirmwareChecker.cxx

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,15 @@ namespace AliceO2
2121
namespace roc
2222
{
2323

24-
FirmwareChecker::FirmwareChecker() : mCompatibleFirmwareList({ { "20191126-124721-6baf11da", "v3.5.1" },
25-
{ "20191114-171438-5b162edd", "v3.5.0" },
26-
{ "20191014-115705-51882687", "v3.4.0" },
27-
{ "20190911-150139-3f5e11b3", "v3.3.0" },
28-
{ "20190718-120712-4c8e6c48", "v3.2.0" },
29-
{ "0.0:2000-0-0", "alpha" } })
24+
FirmwareChecker::FirmwareChecker() : mCompatibleFirmwareList({ /* CRU */
25+
{ "d458317e", "v3.5.2" },
26+
{ "6baf11da", "v3.5.1" },
27+
{ "5b162edd", "v3.5.0" },
28+
{ "51882687", "v3.4.0" },
29+
{ "3f5e11b3", "v3.3.0" },
30+
{ "4c8e6c48", "v3.2.0" },
31+
/* CRORC */
32+
{ "0", "alpha" } })
3033
{
3134
}
3235

@@ -36,6 +39,7 @@ FirmwareChecker::~FirmwareChecker()
3639

3740
std::string FirmwareChecker::resolveFirmwareTag(std::string firmware)
3841
{
42+
firmware = firmware.substr(firmware.find_last_of("-") + 1);
3943
if (mCompatibleFirmwareList.find(firmware) != mCompatibleFirmwareList.end()) {
4044
return mCompatibleFirmwareList.at(firmware);
4145
} else {
@@ -55,6 +59,7 @@ std::string FirmwareChecker::getFirmwareCompatibilityList()
5559
void FirmwareChecker::checkFirmwareCompatibilityWrapped(std::shared_ptr<BarInterface> bar2)
5660
{
5761
auto firmware = bar2->getFirmwareInfo().value_or("");
62+
firmware = firmware.substr(firmware.find_last_of("-") + 1);
5863
auto serial = bar2->getSerial().value_or(-1);
5964
if (mCompatibleFirmwareList.find(firmware) == mCompatibleFirmwareList.end()) {
6065
BOOST_THROW_EXCEPTION(Exception() << ErrorInfo::Message(

0 commit comments

Comments
 (0)