Skip to content

Commit 56f9c28

Browse files
committed
Add warning message for variable dma page sizes
1 parent bc8a7e6 commit 56f9c28

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/Cru/CruDmaChannel.cxx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,14 @@ CruDmaChannel::CruDmaChannel(const Parameters& parameters)
4343
mDmaPageSize(parameters.getDmaPageSize().get_value_or(Cru::DMA_PAGE_SIZE))
4444
{
4545

46-
//TODO: Figure out how to approach errors here
47-
//TODO: PageSize > 0?8?128? PageSize< 8K?
48-
/*if (auto pageSize = parameters.getDmaPageSize()) {
46+
if (auto pageSize = parameters.getDmaPageSize()) {
4947
if (pageSize.get() != Cru::DMA_PAGE_SIZE) {
50-
BOOST_THROW_EXCEPTION(CruException()
48+
log("DMA page size not default; Behaviour undefined", InfoLogger::InfoLogger::Warning);
49+
/*BOOST_THROW_EXCEPTION(CruException()
5150
<< ErrorInfo::Message("CRU only supports an 8KiB page size")
52-
<< ErrorInfo::DmaPageSize(pageSize.get()));
51+
<< ErrorInfo::DmaPageSize(pageSize.get()));*/
5352
}
54-
}*/
53+
}
5554

5655
if (mLoopbackMode == LoopbackMode::Diu || mLoopbackMode == LoopbackMode::Siu) {
5756
BOOST_THROW_EXCEPTION(CruException() << ErrorInfo::Message("CRU does not support given loopback mode")

0 commit comments

Comments
 (0)