[roc-cleanup] Ignore system() return value

Author: kostorr

src/CommandLineUtilities/ProgramCleanup.cxx

@@ -17,7 +17,6 @@
 #include <boost/algorithm/string/predicate.hpp>
 #include <boost/filesystem.hpp>
 #include <iostream>
-#include "Common/System.h"
 #include "ReadoutCard/ChannelFactory.h"
 #include "CommandLineUtilities/Common.h"
 #include "CommandLineUtilities/Options.h"
@@ -74,28 +73,34 @@ class ProgramCleanup : public Program
     Pda::freePdaDmaBuffers();
 
     std::cout << "Removing CRORC FIFO shared memory files" << std::endl;
-    system("rm /dev/shm/AliceO2_RoC_*");
+    sysIgnored("rm /dev/shm/AliceO2_RoC_*");
     std::cout << "Removing readout 2MB hugepage mappings" << std::endl;
-    system("rm /var/lib/hugetlbfs/global/pagesize-2MB/readout*");
+    sysIgnored("rm /var/lib/hugetlbfs/global/pagesize-2MB/readout*");
     std::cout << "Removing readout 1GB hugepage mappings" << std::endl;
-    system("rm /var/lib/hugetlbfs/global/pagesize-1GB/readout*");
+    sysIgnored("rm /var/lib/hugetlbfs/global/pagesize-1GB/readout*");
     std::cout << "Removing roc-bench-dma 2MB hugepage mappings" << std::endl;
-    system("rm /var/lib/hugetlbfs/global/pagesize-2MB/roc-bench-dma*");
+    sysIgnored("rm /var/lib/hugetlbfs/global/pagesize-2MB/roc-bench-dma*");
     std::cout << "Removing roc-bench-dma 1GB hugepage mappings" << std::endl;
-    system("rm /var/lib/hugetlbfs/global/pagesize-1GB/roc-bench-dma*");
+    sysIgnored("rm /var/lib/hugetlbfs/global/pagesize-1GB/roc-bench-dma*");
 
     if (!mOptions.light) {
       std::cout << "Removing uio_pci_dma" << std::endl;
-      system("modprobe -r uio_pci_dma");
+      sysIgnored("modprobe -r uio_pci_dma");
       std::cout << "Reinserting uio_pci_dma" << std::endl;
-      system("modprobe uio_pci_dma");
+      sysIgnored("modprobe uio_pci_dma");
     }
   }
 
  private:
   struct OptionsStruct {
     bool light = false;
   } mOptions;
+
+  // Ignore system()'s return value
+  void sysIgnored(const char* command)
+  {
+    static_cast<void>(system(command));
+  }
 };
 
 int main(int argc, char** argv)