[roc-config] Improve user feedback for invalid options

Author: kostorr

src/CardConfigurator.cxx

@@ -105,7 +105,6 @@ void CardConfigurator::parseConfigUriCru(std::string configUri, Parameters& para
   try {
     conf = o2::configuration::ConfigurationFactory::getConfiguration(configUri);
   } catch (std::exception& e) {
-    std::cout << boost::diagnostic_information(e) << std::endl;
     throw;
   }
 

src/CommandLineUtilities/ProgramConfig.cxx

@@ -27,7 +27,6 @@
 
 using namespace AliceO2::roc::CommandLineUtilities;
 using namespace AliceO2::roc;
-using namespace AliceO2::InfoLogger;
 namespace po = boost::program_options;
 
 class ProgramConfig : public Program
@@ -168,7 +167,7 @@ class ProgramConfig : public Program
         FirmwareChecker().checkFirmwareCompatibility(cardId);
       } catch (const Exception& e) {
         Logger::get() << boost::diagnostic_information(e) << LogErrorOps << endm;
-        throw(e);
+        throw;
       }
     }
 
@@ -243,16 +242,16 @@ class ProgramConfig : public Program
       try {
         CardConfigurator(params, mOptions.forceConfig);
       } catch (const Exception& e) {
-        Logger::get() << boost::diagnostic_information(e) << LogErrorOps << endm;
-        throw(e);
+        Logger::get() << e.what() << LogErrorOps << endm;
+        throw;
       }
     } else {
       Logger::get() << "Configuring with config uri" << LogDebugOps << endm;
       try {
         CardConfigurator(cardId, mOptions.configUri, mOptions.forceConfig);
-      } catch (std::runtime_error& e) {
-        Logger::get() << "Error parsing the configuration..." << boost::diagnostic_information(e) << LogErrorOps << endm;
-        throw(e);
+      } catch (std::exception& e) {
+        Logger::get() << e.what() << LogErrorOps << endm;
+        throw;
       }
     }
     return;

src/Utilities/Enum.h

@@ -52,7 +52,13 @@ struct EnumConverter {
         return pair.first;
       }
     }
-    BOOST_THROW_EXCEPTION(std::runtime_error("Failed to convert string to " + typeName + " enum"));
+
+    std::string errString = "Failed to convert string \"" + string + "\" to " + typeName + " enum\nPossible values:";
+    for (const auto& el : mapping) {
+      errString += " \"" + el.second + "\"";
+    }
+
+    BOOST_THROW_EXCEPTION(std::runtime_error(errString));
   }
 };