Skip to content

Commit 7c8bbb3

Browse files
authored
Simplify list conversion in script utilities (#448)
* Add make_list * Remove list variables * Use proper conversion
1 parent f52d7f6 commit 7c8bbb3

File tree

1 file changed

+17
-10
lines changed

1 file changed

+17
-10
lines changed

FirstAnalysis/hf_analysis_utils.py

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@
99
import numpy as np # pylint: disable=import-error
1010

1111

12+
def make_list(object) -> list:
13+
"""
14+
Returns the object as a list if it is not a list already.
15+
"""
16+
return object if isinstance(object, list) else list(object)
17+
18+
1219
# pylint: disable=too-many-arguments
1320
def compute_crosssection(
1421
rawy,
@@ -84,10 +91,10 @@ def compute_fraction_fc(
8491
- frac_fd: list of fraction of non-prompt D (central, min, max)
8592
"""
8693

87-
cross_sec_prompt_l = cross_sec_prompt if isinstance(cross_sec_prompt, list) else [cross_sec_prompt]
88-
cross_sec_fd_l = cross_sec_fd if isinstance(cross_sec_fd, list) else [cross_sec_fd]
89-
raa_prompt_l = raa_prompt if isinstance(raa_prompt, list) else [raa_prompt]
90-
raa_fd_l = raa_fd if isinstance(raa_fd, list) else [raa_fd]
94+
cross_sec_prompt = make_list(cross_sec_prompt)
95+
cross_sec_fd = make_list(cross_sec_fd)
96+
raa_prompt = make_list(raa_prompt)
97+
raa_fd = make_list(raa_fd)
9198

9299
frac_prompt: list[float] = []
93100
frac_fd: list[float] = []
@@ -104,8 +111,8 @@ def compute_fraction_fc(
104111
frac_fd = [frac_fd_cent, frac_fd_cent, frac_fd_cent]
105112
return frac_prompt, frac_fd
106113

107-
for i_sigma, (sigma_p, sigma_f) in enumerate(zip(cross_sec_prompt_l, cross_sec_fd_l)):
108-
for i_raa, (raa_p, raa_f) in enumerate(zip(raa_prompt_l, raa_fd_l)):
114+
for i_sigma, (sigma_p, sigma_f) in enumerate(zip(cross_sec_prompt, cross_sec_fd)):
115+
for i_raa, (raa_p, raa_f) in enumerate(zip(raa_prompt, raa_fd)):
109116
if i_sigma == 0 and i_raa == 0:
110117
frac_prompt_cent = 1.0 / (1 + acc_eff_fd / acc_eff_prompt * sigma_f / sigma_p * raa_f / raa_p)
111118
frac_fd_cent = 1.0 / (1 + acc_eff_prompt / acc_eff_fd * sigma_p / sigma_f * raa_p / raa_f)
@@ -162,12 +169,12 @@ def compute_fraction_nb(
162169
- frac: list of fraction of prompt (non-prompt) D (central, min, max)
163170
"""
164171

165-
crosssection_l = crosssection if isinstance(crosssection, list) else [crosssection]
166-
raa_ratio_l = raa_ratio if isinstance(raa_ratio, list) else [raa_ratio]
172+
crosssection = make_list(crosssection)
173+
raa_ratio = make_list(raa_ratio)
167174

168175
frac: list[float] = []
169-
for i_sigma, sigma in enumerate(crosssection_l):
170-
for i_raa_ratio, raa_rat in enumerate(raa_ratio_l):
176+
for i_sigma, sigma in enumerate(crosssection):
177+
for i_raa_ratio, raa_rat in enumerate(raa_ratio):
171178
raa_other = 1.0
172179
if i_sigma == 0 and i_raa_ratio == 0:
173180
if raa_rat == 1.0 and taa == 1.0: # pp

0 commit comments

Comments
 (0)