Skip to content

Commit 64d9b6c

Browse files
committed
PWGHF: Remove unneccessary PR instructions
Those are already part of the main instructions.
1 parent 71eaa35 commit 64d9b6c

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

docs/advanced-specifics/pwghf.md

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -249,27 +249,11 @@ Example:
249249
- main task (`struct`) name: `HfTaskXY` (results in the generated device name `hf-task-x-y`)
250250
- auxiliary-task name: `HfTaskXY<Suffix>` (results in the generated device name `hf-task-x-y-<suffix>`)
251251

252-
### Git
253-
254-
- If your changes consist of several independent steps, keep them separate in several commits.
255-
- Give your commits meaningful titles.
256-
- If needed, add more details in the commit message (separated by a blank line from the commit title).
257-
- Keep your feature branch up to date with the upstream main branch (`git pull --rebase upstream master`).
258-
259252
### Pull requests (PR)
260253

261254
- Update your branch and test it before creating a PR.
262-
- Create one PR per feature (i.e. do not mix big unrelated code changes).
263255
- Give your PR a short meaningful title.
264256
- Add the “PWGHF: ” prefix in the title of your PR. (It helps to search for PWGHF-related PRs in the commit history of the main branch.)
265257
- Note: If your PR has only one commit, add the prefix also in the commit title (because that is the title that will appear in the history after merging, unless the person merging the PR changes it by hand).
266258
- Give further useful details about your changes in the PR description.
267259
- Add links to all related PRs (e.g. O2Physics, O2, AliPhysics, Run3Analysisvalidation) in the PR description.
268-
269-
#### PR review
270-
271-
- When you implement changes during the review, push them into your branch as new separate commits with meaningful titles.
272-
- Do not amend, squash or rebase existing commits in the PR. It would break the links between the code and the review comments.
273-
- If you need to update your branch with the changes in the main branch while the PR is under review, use `git merge upstream/master` (instead of `rebase`) to preserve the commit history.
274-
- Fix formatting issues by merging the PRs created automatically by the CI tests in your fork repository.
275-
- If you need more time to implement further changes in your PR, convert it to a draft to avoid unnecessary build tests and mark it as ready for review again when you're done.

0 commit comments

Comments
 (0)