You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/advanced-specifics/pwghf.md
-16Lines changed: 0 additions & 16 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -249,27 +249,11 @@ Example:
249
249
- main task (`struct`) name: `HfTaskXY` (results in the generated device name `hf-task-x-y`)
250
250
- auxiliary-task name: `HfTaskXY<Suffix>` (results in the generated device name `hf-task-x-y-<suffix>`)
251
251
252
-
### Git
253
-
254
-
- If your changes consist of several independent steps, keep them separate in several commits.
255
-
- Give your commits meaningful titles.
256
-
- If needed, add more details in the commit message (separated by a blank line from the commit title).
257
-
- Keep your feature branch up to date with the upstream main branch (`git pull --rebase upstream master`).
258
-
259
252
### Pull requests (PR)
260
253
261
254
- Update your branch and test it before creating a PR.
262
-
- Create one PR per feature (i.e. do not mix big unrelated code changes).
263
255
- Give your PR a short meaningful title.
264
256
- Add the “PWGHF: ” prefix in the title of your PR. (It helps to search for PWGHF-related PRs in the commit history of the main branch.)
265
257
- Note: If your PR has only one commit, add the prefix also in the commit title (because that is the title that will appear in the history after merging, unless the person merging the PR changes it by hand).
266
258
- Give further useful details about your changes in the PR description.
267
259
- Add links to all related PRs (e.g. O2Physics, O2, AliPhysics, Run3Analysisvalidation) in the PR description.
268
-
269
-
#### PR review
270
-
271
-
- When you implement changes during the review, push them into your branch as new separate commits with meaningful titles.
272
-
- Do not amend, squash or rebase existing commits in the PR. It would break the links between the code and the review comments.
273
-
- If you need to update your branch with the changes in the main branch while the PR is under review, use `git merge upstream/master` (instead of `rebase`) to preserve the commit history.
274
-
- Fix formatting issues by merging the PRs created automatically by the CI tests in your fork repository.
275
-
- If you need more time to implement further changes in your PR, convert it to a draft to avoid unnecessary build tests and mark it as ready for review again when you're done.
0 commit comments