fix error page visit must exist red herring

Author: dajinchu

bifrost/lib/turbolinks/index.ts

@@ -50,10 +50,9 @@ export const Turbolinks = {
   // Returns promise for turbolinks to be ready to render (runs requestAnimationFrame internally)
   async _vikeBeforeRender(
     visit: Visit | undefined,
-    errorWhileRendering: unknown,
     pageContextToCache?: any
   ): Promise<void> {
-    if ((!visit || visit.state === "completed") && !errorWhileRendering) {
+    if (!visit || visit.state === "completed") {
       throw new Error(
         `Bifrost does not support calling navigate() directly. Use navigate from "@alignable/bifrost" or Turbolinks.visit() instead.`
       );

bifrost/renderer/bifrost/onAfterRenderClient.ts

@@ -5,7 +5,7 @@ import { Turbolinks } from "../../lib/turbolinks";
 export default async function bifrostOnAfterRenderClient(
   pageContext: PageContextClient
 ) {
-  if (!pageContext.isHydration) {
+  if (!pageContext.isHydration && !pageContext.errorWhileRendering) {
     await Turbolinks._vikeAfterRender(pageContext._turbolinksVisit, false);
   }
 }

bifrost/renderer/bifrost/onBeforeRenderClient.ts

@@ -5,12 +5,9 @@ import { setBodyAttributes } from "../../lib/elementUtils";
 export default async function bifrostOnBeforeRenderClient(
   pageContext: PageContextClient
 ) {
-  if (!pageContext.isHydration) {
+  if (!pageContext.isHydration && !pageContext.errorWhileRendering) {
     pageContext._shouldEmitBeforeRender = true;
-    await Turbolinks._vikeBeforeRender(
-      pageContext._turbolinksVisit,
-      pageContext.errorWhileRendering
-    );
+    await Turbolinks._vikeBeforeRender(pageContext._turbolinksVisit);
 
     // Copy over body attributes because vike-react only handles body on initial render, and we need to reset when coming from wrapped
     if (pageContext.config.bodyAttributes)

bifrost/renderer/wrapped/onBeforeRenderClient.ts

@@ -53,13 +53,9 @@ export default async function wrappedOnBeforeRenderClient(
   const { head, bodyAttrs } = pageContext._turbolinksProxy!;
   pageContext._shouldEmitBeforeRender = true;
 
-  await Turbolinks._vikeBeforeRender(
-    pageContext._turbolinksVisit,
-    pageContext.errorWhileRendering,
-    {
-      proxyLayoutInfo: pageContext.proxyLayoutInfo,
-    }
-  );
+  await Turbolinks._vikeBeforeRender(pageContext._turbolinksVisit, {
+    proxyLayoutInfo: pageContext.proxyLayoutInfo,
+  });
   const { waitForReload, waitForHeadScripts } = mergeHead(head!);
 
   // If a full reload is required, wait for it here