[tsp-client] Misc fixes (Azure#13078)

* add output-dir warning

* reduce test failures

* fix test clean up

* fix test clean up

---------

Co-authored-by: catalinaperalta <caperal@microsoft.com>

Author: catalinaperalta

tools/tsp-client/src/index.ts

@@ -134,6 +134,11 @@ const parser = yargs(hideBin(process.argv))
         });
     },
     async (argv: any) => {
+      if (argv["output-dir"] !== undefined) {
+        Logger.warn(
+          "'output-dir' option is ignored when 'emitter-output-dir' is specified in emitter options.",
+        );
+      }
       argv["output-dir"] = resolveOutputDir(argv);
       await initCommand(argv);
     },
@@ -218,6 +223,11 @@ const parser = yargs(hideBin(process.argv))
         });
     },
     async (argv: any) => {
+      if (argv["output-dir"] !== undefined) {
+        Logger.warn(
+          "'output-dir' is only used to find directory containing tsp-location.yaml, the value isn't interpolated when 'emitter-output-dir' is specified in emitter options.",
+        );
+      }
       argv["output-dir"] = resolveOutputDir(argv);
       await updateCommand(argv);
     },

tools/tsp-client/test/commands.spec.ts

@@ -38,20 +38,17 @@ describe.sequential("Verify commands", () => {
   });
 
   afterAll(async () => {
-    await rm(joinPaths(repoRoot, "eng", "emitter-package.json"));
-
-    // This is generated in the first test using the command
-    const emitterPackageLock = joinPaths(repoRoot, "eng", "emitter-package-lock.json");
-    if (await doesFileExist(emitterPackageLock)) {
-      await rm(emitterPackageLock);
-    }
-
-    await rm("./test/examples/sdk/local-spec-sdk/TempTypeSpecFiles/", { recursive: true });
-    await rm("./test/examples/initGlobalConfig/", { recursive: true });
-    await rm("./test/examples/initGlobalConfigNoMatch/", { recursive: true });
+    await rm(joinPaths(repoRoot, "eng", "emitter-package.json"), { force: true });
+    await rm(joinPaths(repoRoot, "eng", "emitter-package-lock.json"), { force: true });
+    await rm("./test/examples/sdk/local-spec-sdk/TempTypeSpecFiles/", {
+      recursive: true,
+      force: true,
+    });
+    await rm("./test/examples/initGlobalConfig/", { recursive: true, force: true });
+    await rm("./test/examples/initGlobalConfigNoMatch/", { recursive: true, force: true });
     await rm(
       "./test/examples/sdk/contosowidgetmanager/contosowidgetmanager-rest/TempTypeSpecFiles/",
-      { recursive: true },
+      { recursive: true, force: true },
     );
     await rm(joinPaths(repoRoot, "sdk/keyvault"), { recursive: true, force: true });
   });

tools/tsp-client/test/metadata.spec.ts

@@ -41,7 +41,7 @@ describe.sequential("tsp-client metadata generation", function () {
 
   afterEach(async function () {
     // Clean up test files
-    await removeDirectory(testOutputDir).catch(() => {});
+    await rm(testOutputDir, { recursive: true, force: true });
   });
 
   it("should create tsp-client-metadata.yaml with correct structure", async function () {

tools/tsp-client/test/utils.spec.ts

@@ -134,7 +134,7 @@ describe("Verify fs functions", function () {
   });
 
   afterAll(async () => {
-    await rm(joinPaths(await getRepoRoot("."), "eng", "tsp-client-config.yaml"));
+    await rm(joinPaths(await getRepoRoot("."), "eng", "tsp-client-config.yaml"), { force: true });
   });
 
   it("Check parseTspClientRepoConfig", async function () {