Add support for samesign flag
#1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
What? @nunoplopes Can you check the CI configuration? I don't think this patch can be compiled as llvm/llvm-project#111419 was just landed. |
Member
The CI doesn't link against LLVM. It builds just the 'alive' tool (because we need LLVM built with RTTI, and thus we would need to either build LLVM from scratch or cache an image somewhere) |
nunoplopes
reviewed
Oct 15, 2024
dtcxzyw
added a commit
to llvm/llvm-project
that referenced
this pull request
Oct 16, 2024
In #93591 we introduced `isKnownInversion` and assumes `X` is poison implies `Y` is poison because they share common operands. But after introducing `samesign` this assumption no longer hold if `X` is an icmp has `samesign` flag. Alive2 link: https://alive2.llvm.org/ce/z/rj3EwQ (Please run it locally with this patch and AliveToolkit/alive2#1098). This approach is the most conservative way in my mind to address this problem. If `X` has `samesign` flag, it will check if `Y` also has this flag and make sure constant RHS operands have the same sign. Fixes #112350.
jmciver
added a commit
to jmciver/alive2
that referenced
this pull request
Jan 2, 2025
This reverts commit faf59b5.
jmciver
added a commit
to jmciver/alive2
that referenced
this pull request
Jan 15, 2025
This reverts commit faf59b5.
jmciver
added a commit
to jmciver/alive2
that referenced
this pull request
Jan 27, 2025
This reverts commit faf59b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC link: https://discourse.llvm.org/t/rfc-signedness-independent-icmps/81423
llvm/llvm-project#111419 has been landed.