improve dead body ability performance

XtraCube · XtraCube · commit ffeb34baa4f9 · 2025-10-04T14:11:00.000-04:00
diff --git a/LaunchpadReloaded/Buttons/Crewmate/FreezeButton.cs b/LaunchpadReloaded/Buttons/Crewmate/FreezeButton.cs
@@ -9,7 +9,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
-using Helpers = MiraAPI.Utilities.Helpers;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons.Crewmate;
 
@@ -33,7 +33,7 @@ public override bool Enabled(RoleBehaviour? role)
 
     public override DeadBody? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);
     }
 
     public override bool IsTargetValid(DeadBody? target)
diff --git a/LaunchpadReloaded/Buttons/Crewmate/InvestigateButton.cs b/LaunchpadReloaded/Buttons/Crewmate/InvestigateButton.cs
@@ -7,7 +7,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
-using Helpers = MiraAPI.Utilities.Helpers;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons.Crewmate;
 
@@ -31,7 +31,7 @@ public override bool Enabled(RoleBehaviour? role)
 
     public override DeadBody? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);
     }
 
     public override bool IsTargetValid(DeadBody? target)
diff --git a/LaunchpadReloaded/Buttons/Crewmate/ReviveButton.cs b/LaunchpadReloaded/Buttons/Crewmate/ReviveButton.cs
@@ -11,7 +11,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
-using Helpers = MiraAPI.Utilities.Helpers;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons.Crewmate;
 
@@ -50,7 +50,7 @@ public override void SetOutline(bool active)
 
     public override DeadBody? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);
     }
 
     public override bool IsTargetValid(DeadBody? target)
diff --git a/LaunchpadReloaded/Buttons/Crewmate/SealButton.cs b/LaunchpadReloaded/Buttons/Crewmate/SealButton.cs
@@ -9,7 +9,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
-using Helpers = MiraAPI.Utilities.Helpers;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons.Crewmate;
 
@@ -33,7 +33,7 @@ public override bool Enabled(RoleBehaviour? role)
 
     public override Vent? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<Vent>(Distance, Helpers.CreateFilter(Constants.NotShipMask));
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<Vent>(Distance, Helpers.BodyFilter2D);
     }
 
     public override bool IsTargetValid(Vent? target)
diff --git a/LaunchpadReloaded/Buttons/DragButton.cs b/LaunchpadReloaded/Buttons/DragButton.cs
@@ -12,7 +12,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
-using Helpers = MiraAPI.Utilities.Helpers;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons;
 
@@ -36,7 +36,7 @@ public override bool Enabled(RoleBehaviour? role)
 
     public override DeadBody? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);
     }
 
     public override bool IsTargetValid(DeadBody? target)
diff --git a/LaunchpadReloaded/Buttons/Impostor/DissectButton.cs b/LaunchpadReloaded/Buttons/Impostor/DissectButton.cs
@@ -9,7 +9,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
-using Helpers = MiraAPI.Utilities.Helpers;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons.Impostor;
 
@@ -32,7 +32,7 @@ public override bool Enabled(RoleBehaviour? role)
 
     public override DeadBody? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);
     }
 
     public override bool IsTargetValid(DeadBody? target)
diff --git a/LaunchpadReloaded/Buttons/Impostor/HideButton.cs b/LaunchpadReloaded/Buttons/Impostor/HideButton.cs
@@ -11,7 +11,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
-using Helpers = MiraAPI.Utilities.Helpers;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons.Impostor;
 
@@ -32,7 +32,7 @@ public class HideButton : BaseLaunchpadButton<DeadBody>
 
     public override DeadBody? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);
     }
 
     public override bool IsTargetValid(DeadBody? target)
diff --git a/LaunchpadReloaded/Buttons/Neutral/CollectButton.cs b/LaunchpadReloaded/Buttons/Neutral/CollectButton.cs
@@ -9,6 +9,7 @@
 using MiraAPI.Utilities.Assets;
 using Rewired;
 using UnityEngine;
+using Helpers = LaunchpadReloaded.Utilities.Helpers;
 
 namespace LaunchpadReloaded.Buttons.Neutral;
 
@@ -31,7 +32,7 @@ public override bool Enabled(RoleBehaviour? role)
 
     public override DeadBody? GetTarget()
     {
-        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, MiraAPI.Utilities.Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);
+        return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);
     }
 
     public override bool IsTargetValid(DeadBody? target)
diff --git a/LaunchpadReloaded/Patches/Generic/GameManagerPatch.cs b/LaunchpadReloaded/Patches/Generic/GameManagerPatch.cs
@@ -1,5 +1,6 @@
 ﻿using HarmonyLib;
 using LaunchpadReloaded.Components;
+using Reactor.Utilities;
 
 namespace LaunchpadReloaded.Patches.Generic;
 
@@ -11,6 +12,7 @@ public static void Postfix(GameManager __instance)
         foreach (var deadBody in __instance.deadBodyPrefab)
         {
             deadBody.gameObject.AddComponent<DeadBodyCacheComponent>();
+            Logger<LaunchpadReloadedPlugin>.Info("Added DeadBodyCacheComponent to dead body prefab");
         }
     }
 }
diff --git a/LaunchpadReloaded/Utilities/Helpers.cs b/LaunchpadReloaded/Utilities/Helpers.cs
@@ -10,6 +10,9 @@ namespace LaunchpadReloaded.Utilities;
 public static class Helpers
 {
     public static readonly Random Random = new();
+    
+    private static ContactFilter2D? _bodyFilter2D;
+    public static ContactFilter2D BodyFilter2D => _bodyFilter2D ??= MiraAPI.Utilities.Helpers.CreateFilter(Constants.NotShipMask);
 
     public static bool ShouldCancelClick()
     {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`using MiraAPI.Utilities.Assets;`
`10`	`10`	`using Rewired;`
`11`	`11`	`using UnityEngine;`
`12`		`-using Helpers = MiraAPI.Utilities.Helpers;`
	`12`	`+using Helpers = LaunchpadReloaded.Utilities.Helpers;`
`13`	`13`
`14`	`14`	`namespace LaunchpadReloaded.Buttons.Crewmate;`
`15`	`15`
`@@ -33,7 +33,7 @@ public override bool Enabled(RoleBehaviour? role)`
`33`	`33`
`34`	`34`	`public override DeadBody? GetTarget()`
`35`	`35`	`{`
`36`		`- return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);`
	`36`	`+ return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`public override bool IsTargetValid(DeadBody? target)`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`using MiraAPI.Utilities.Assets;`
`8`	`8`	`using Rewired;`
`9`	`9`	`using UnityEngine;`
`10`		`-using Helpers = MiraAPI.Utilities.Helpers;`
	`10`	`+using Helpers = LaunchpadReloaded.Utilities.Helpers;`
`11`	`11`
`12`	`12`	`namespace LaunchpadReloaded.Buttons.Crewmate;`
`13`	`13`
`@@ -31,7 +31,7 @@ public override bool Enabled(RoleBehaviour? role)`
`31`	`31`
`32`	`32`	`public override DeadBody? GetTarget()`
`33`	`33`	`{`
`34`		`- return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);`
	`34`	`+ return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`public override bool IsTargetValid(DeadBody? target)`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`using MiraAPI.Utilities.Assets;`
`12`	`12`	`using Rewired;`
`13`	`13`	`using UnityEngine;`
`14`		`-using Helpers = MiraAPI.Utilities.Helpers;`
	`14`	`+using Helpers = LaunchpadReloaded.Utilities.Helpers;`
`15`	`15`
`16`	`16`	`namespace LaunchpadReloaded.Buttons.Crewmate;`
`17`	`17`
`@@ -50,7 +50,7 @@ public override void SetOutline(bool active)`
`50`	`50`
`51`	`51`	`public override DeadBody? GetTarget()`
`52`	`52`	`{`
`53`		`- return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);`
	`53`	`+ return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`public override bool IsTargetValid(DeadBody? target)`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`using MiraAPI.Utilities.Assets;`
`13`	`13`	`using Rewired;`
`14`	`14`	`using UnityEngine;`
`15`		`-using Helpers = MiraAPI.Utilities.Helpers;`
	`15`	`+using Helpers = LaunchpadReloaded.Utilities.Helpers;`
`16`	`16`
`17`	`17`	`namespace LaunchpadReloaded.Buttons;`
`18`	`18`
`@@ -36,7 +36,7 @@ public override bool Enabled(RoleBehaviour? role)`
`36`	`36`
`37`	`37`	`public override DeadBody? GetTarget()`
`38`	`38`	`{`
`39`		`- return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);`
	`39`	`+ return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`public override bool IsTargetValid(DeadBody? target)`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`using MiraAPI.Utilities.Assets;`
`10`	`10`	`using Rewired;`
`11`	`11`	`using UnityEngine;`
	`12`	`+using Helpers = LaunchpadReloaded.Utilities.Helpers;`
`12`	`13`
`13`	`14`	`namespace LaunchpadReloaded.Buttons.Neutral;`
`14`	`15`
`@@ -31,7 +32,7 @@ public override bool Enabled(RoleBehaviour? role)`
`31`	`32`
`32`	`33`	`public override DeadBody? GetTarget()`
`33`	`34`	`{`
`34`		`- return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, MiraAPI.Utilities.Helpers.CreateFilter(Constants.NotShipMask), "DeadBody", IsTargetValid);`
	`35`	`+ return PlayerControl.LocalPlayer.GetNearestObjectOfType<DeadBody>(Distance, Helpers.BodyFilter2D, "DeadBody", IsTargetValid);`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`public override bool IsTargetValid(DeadBody? target)`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using HarmonyLib;`
`2`	`2`	`using LaunchpadReloaded.Components;`
	`3`	`+using Reactor.Utilities;`
`3`	`4`
`4`	`5`	`namespace LaunchpadReloaded.Patches.Generic;`
`5`	`6`
`@@ -11,6 +12,7 @@ public static void Postfix(GameManager __instance)`
`11`	`12`	`foreach (var deadBody in __instance.deadBodyPrefab)`
`12`	`13`	`{`
`13`	`14`	`deadBody.gameObject.AddComponent<DeadBodyCacheComponent>();`
	`15`	`+ Logger<LaunchpadReloadedPlugin>.Info("Added DeadBodyCacheComponent to dead body prefab");`
`14`	`16`	`}`
`15`	`17`	`}`
`16`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,9 @@ namespace LaunchpadReloaded.Utilities;`
`10`	`10`	`public static class Helpers`
`11`	`11`	`{`
`12`	`12`	`public static readonly Random Random = new();`
	`13`	`+`
	`14`	`+ private static ContactFilter2D? _bodyFilter2D;`
	`15`	`+ public static ContactFilter2D BodyFilter2D => _bodyFilter2D ??= MiraAPI.Utilities.Helpers.CreateFilter(Constants.NotShipMask);`
`13`	`16`
`14`	`17`	`public static bool ShouldCancelClick()`
`15`	`18`	`{`