Review feedback

Author: kdumontnu

.drone.yml

@@ -546,10 +546,9 @@ steps:
   - name: test-e2e
     image: mcr.microsoft.com/playwright:v1.23.1-focal
     commands:
-      - curl -sL https://go.dev/dl/go1.18.3.linux-amd64.tar.gz -o go1.18.3.linux-amd64.tar.gz && tar -C /usr/local -xzf go1.18.3.linux-amd64.tar.gz
+      - curl -sLO https://go.dev/dl/go1.18.linux-amd64.tar.gz && tar -C /usr/local -xzf go1.18.linux-amd64.tar.gz
       - groupadd --gid 1001 gitea && useradd -m --gid 1001 --uid 1001 gitea
-      - apt-get update
-      - apt-get install build-essential --yes
+      - apt-get -qq update && apt-get -qqy install build-essential
       - export TEST_PGSQL_SCHEMA=''
       - ./build/test-env-prepare.sh
       - su gitea bash -c "export PATH=$PATH:/usr/local/go/bin && timeout -s ABRT 40m make test-e2e-pgsql"
@@ -559,7 +558,7 @@ steps:
       USE_REPO_TEST_DIR: 1
       NO_DEPS_PLAYWRIGHT: 1
       TEST_PGSQL_DBNAME: 'testgitea-e2e'
-      NPX_FLAGS: '--yes'
+      DEBIAN_FRONTEND: noninteractive
     depends_on: [build-frontend, deps-backend]
 
 ---

Makefile

@@ -327,7 +327,7 @@ lint: lint-frontend lint-backend
 
 .PHONY: lint-frontend
 lint-frontend: node_modules
-	npx eslint --color --max-warnings=0 --ext js,vue web_src/js build *.config.js docs/assets/js tests/e2e/*.test.e2e.js
+	npx eslint --color --max-warnings=0 --ext js,vue web_src/js build *.config.js docs/assets/js tests/e2e/*.test.e2e.js tests/e2e/utils_e2e.js
 	npx stylelint --color --max-warnings=0 web_src/less
 	npx spectral lint -q -F hint $(SWAGGER_SPEC)
 	npx markdownlint docs *.md

package-lock.json

@@ -46,8 +46,8 @@
     "wrap-ansi": "8.0.1"
   },
   "devDependencies": {
-    "@stoplight/spectral-cli": "6.5.1",
     "@playwright/test": "1.25.1",
+    "@stoplight/spectral-cli": "6.5.1",
     "eslint": "8.22.0",
     "eslint-plugin-import": "2.26.0",
     "eslint-plugin-jquery": "1.5.1",