Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

Commit cd5a50c

Browse files
authored
Remove ceiling on Pillow; adjust default reader expectations (#543)
1 parent 797bcab commit cd5a50c

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

aicsimageio/tests/readers/extra_readers/test_default_reader.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
@pytest.mark.parametrize(
1919
"filename, set_scene, expected_shape, expected_dims_order",
2020
[
21-
("example.bmp", "Image:0", (480, 640, 4), "YXS"),
2221
("example.png", "Image:0", (800, 537, 4), "YXS"),
2322
("example.jpg", "Image:0", (452, 400, 3), "YXS"),
24-
("example.gif", "Image:0", (72, 268, 268, 4), "TYXS"),
23+
("example.gif", "Image:0", (72, 268, 268, 3), "TYXS"),
2524
(
2625
"example_invalid_frame_count.mp4",
2726
"Image:0",
@@ -108,7 +107,7 @@ def test_ffmpeg_header_fail() -> None:
108107
"example.gif",
109108
"Image:0",
110109
("Image:0",),
111-
(72, 1, 1, 268, 268, 4),
110+
(72, 1, 1, 268, 268, 3),
112111
np.uint8,
113112
dimensions.DEFAULT_DIMENSION_ORDER_WITH_SAMPLES,
114113
["Channel:0:0"],
@@ -175,7 +174,7 @@ def test_aicsimage(
175174
None,
176175
dimensions.DEFAULT_DIMENSION_ORDER_WITH_SAMPLES,
177176
["Channel:0:0"],
178-
(72, 1, 1, 268, 268, 4),
177+
(72, 1, 1, 268, 268, 3),
179178
),
180179
# Check just dims to see default channel name creation
181180
(
@@ -184,18 +183,18 @@ def test_aicsimage(
184183
"ZYXC",
185184
None,
186185
dimensions.DEFAULT_DIMENSION_ORDER,
187-
["Channel:0:0", "Channel:0:1", "Channel:0:2", "Channel:0:3"],
188-
(1, 4, 72, 268, 268),
186+
["Channel:0:0", "Channel:0:1", "Channel:0:2"],
187+
(1, 3, 72, 268, 268),
189188
),
190189
# Check setting both as simple definitions
191190
(
192191
"example.gif",
193192
"Image:0",
194193
"ZYXC",
195-
["Red", "Green", "Blue", "Alpha"],
194+
["Red", "Green", "Blue"],
196195
dimensions.DEFAULT_DIMENSION_ORDER,
197-
["Red", "Green", "Blue", "Alpha"],
198-
(1, 4, 72, 268, 268),
196+
["Red", "Green", "Blue"],
197+
(1, 3, 72, 268, 268),
199198
),
200199
# Check providing too many dims
201200
pytest.param(
@@ -213,7 +212,7 @@ def test_aicsimage(
213212
"example.gif",
214213
"Image:0",
215214
"ZYXC",
216-
["A", "B", "C"],
215+
["A", "B", "C", "D"],
217216
None,
218217
None,
219218
None,

aicsimageio/tests/writers/extra_writers/test_timeseries_writer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
@pytest.mark.parametrize(
1818
"write_shape, write_dim_order, read_shape, read_dim_order",
1919
[
20-
((30, 100, 100), None, (30, 100, 100), "TYX"),
20+
((30, 100, 100), None, (30, 100, 100, 3), "TYXS"),
2121
# Note that files get saved out with RGBA, instead of just RGB
22-
((30, 100, 100, 3), None, (30, 100, 100, 4), "TYXS"),
23-
((100, 30, 100), "XTY", (30, 100, 100), "TYX"),
22+
((30, 100, 100, 3), None, (30, 100, 100, 3), "TYXS"),
23+
((100, 30, 100), "XTY", (30, 100, 100, 3), "TYXS"),
2424
# Note that files get saved out with RGBA, instead of just RGB
25-
((3, 100, 30, 100), "SYTX", (30, 100, 100, 4), "TYXS"),
25+
((3, 100, 30, 100), "SYTX", (30, 100, 100, 3), "TYXS"),
2626
pytest.param(
2727
(1, 1),
2828
None,

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def run(self):
3131
# "READER_TO_INSTALL" lookup table from aicsimageio/formats.py.
3232
format_libs: Dict[str, List[str]] = {
3333
"base-imageio": [
34-
"imageio[ffmpeg]>=2.11.0,<2.28.0",
34+
"imageio[ffmpeg]>=2.31.0",
3535
"Pillow>=9.3.0",
3636
],
3737
"nd2": ["nd2[legacy]>=0.6.0"],

0 commit comments

Comments
 (0)