diff --git a/bioloaders/data/allen/integrated_cell.py b/bioloaders/data/allen/integrated_cell.py index f246710..fa676cb 100644 --- a/bioloaders/data/allen/integrated_cell.py +++ b/bioloaders/data/allen/integrated_cell.py @@ -130,7 +130,26 @@ def download(self): f.write(data.read()) with tarfile.open(file_path) as zip_f: - zip_f.extractall(path=self.root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(zip_f, path=self.root) os.unlink(file_path) print('Done!')