Fix a crash

Alphalaneous · Alphalaneous · commit 5f72c1d8a628 · 2025-11-27T03:46:17.000-05:00
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,6 @@
+# 1.2.3
+- Fix a crash when an invalid directory exists
+
 # 1.2.2
 - Fix a crash
 
diff --git a/mod.json b/mod.json
@@ -6,7 +6,7 @@
 		"mac": "2.2074",
 		"ios": "2.2074"
 	},
-	"version": "v1.2.2",
+	"version": "v1.2.3",
 	"id": "alphalaneous.editorsounds",
 	"name": "Editor Sounds",
 	"developer": "Alphalaneous",
diff --git a/src/SoundEvent.cpp b/src/SoundEvent.cpp
@@ -27,7 +27,8 @@ SoundEvent SoundEvent::create(std::string soundName, OnSoundEvent onEvent, Sound
     if (Mod::get()->getSettingValue<bool>("enable-custom-sounds")) {
         soundPath = Mod::get()->getSettingValue<std::filesystem::path>("custom-sound-path");
     }
-    else {
+
+    if (soundPath.empty() || !std::filesystem::exists(soundPath)) {
         soundPath = Mod::get()->getResourcesDir();
     }
 
diff --git a/src/main.cpp b/src/main.cpp
@@ -4,7 +4,6 @@
 #include <Geode/modify/EditButtonBar.hpp>
 #include <Geode/modify/EditorPauseLayer.hpp>
 #include "CustomKeybinds.hpp"
-#include "Geode/loader/Log.hpp"
 #include "SoundHandler.hpp"
 #include "HijackCallback.hpp"
 

-Original file line number
+Diff line change
@@ @@ -1,3 +1,6 @@ @@
 +# 1.2.3
 +- Fix a crash when an invalid directory exists
++
 # 1.2.2
 - Fix a crash
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,8 @@ SoundEvent SoundEvent::create(std::string soundName, OnSoundEvent onEvent, Sound`
`27`	`27`	`if (Mod::get()->getSettingValue<bool>("enable-custom-sounds")) {`
`28`	`28`	`soundPath = Mod::get()->getSettingValue<std::filesystem::path>("custom-sound-path");`
`29`	`29`	`}`
`30`		`- else {`
	`30`	`+`
	`31`	`+ if (soundPath.empty() \|\| !std::filesystem::exists(soundPath)) {`
`31`	`32`	`soundPath = Mod::get()->getResourcesDir();`
`32`	`33`	`}`
`33`	`34`