Small fix

Author: Alphalaneous

changelog.md

@@ -1,3 +1,6 @@
+# 2.0.23
+- Fix a small oversight that could break transitions
+
 # 2.0.21 & 2.0.22
 - Attempt to fix a rare crash
 

mod.json

@@ -6,7 +6,7 @@
         "mac": "2.2074",
         "ios": "2.2074"
     },
-    "version": "v2.0.22",
+    "version": "v2.0.23",
     "id": "alphalaneous.happy_textures",
     "name": "Happy Textures :3",
     "developer": "Alphalaneous",

src/NodeModding.hpp

@@ -40,6 +40,8 @@ class $modify(HTCCObject, CCObject) {
             MyCCNode* node = reinterpret_cast<MyCCNode*>(this);
 
             auto fields = node->m_fields.self();
+            fields->m_self = node;
+
             if (!fields->m_modified) {
                 modding->setNodeVTable(node);
                 LateQueue::get()->queue(node, [modding, node = Ref(node), fields] {

src/UIModding.cpp

@@ -1614,9 +1614,7 @@ void UIModding::doUICheckForType(std::string_view type, CCNode* node) {
 }
 
 bool UIModding::checkNodeValidity(CCObject* node) {
-    auto ret = *(uintptr_t*)node == m_nodeVTables[node];
-    m_nodeVTables.erase(node);
-    return ret;
+    return *(uintptr_t*)node == m_nodeVTables[node];
 }
 
 void UIModding::setNodeVTable(CCNode* node) {

src/nodes/CCNode.hpp

@@ -13,7 +13,11 @@ class $modify(MyCCNode, CCNode) {
         std::vector<matjson::Value> m_attributes;
         std::vector<CCAction*> m_scheduledAttributes;
         bool m_modified = false;
+        CCNode* m_self;
         std::string m_baseID = "";
+        ~Fields() {
+            UIModding::get()->m_nodeVTables.erase(m_self);
+        }
     };
 
     void setBaseID(const std::string& ID) {
@@ -64,6 +68,8 @@ class $modify(MyCCNode, CCNode) {
     }
 
     void setModified() {
-        m_fields->m_modified = true;
+        auto fields = m_fields.self();
+        fields->m_self = this;
+        fields->m_modified = true;
     }
 };