Fix

Author: Alphalaneous

changelog.md

@@ -1,3 +1,6 @@
+# 2.1.3
+- Fix bug where getting by index required the full namespace of the type
+
 # 2.1.2
 - Add onGeode callback to MenuLayer
 

mod.json

@@ -6,7 +6,7 @@
         "mac": "2.2081",
         "ios": "2.2081"
     },
-    "version": "v2.1.2",
+    "version": "v2.1.3",
     "id": "alphalaneous.happy_textures",
     "name": "Happy Textures :3",
     "developer": "Alphalaneous",

src/UIModding.cpp

@@ -1224,7 +1224,7 @@ void UIModding::modifyChildByIndex(CCNode* node, const matjson::Value& value) {
         }
     }
 
-    UIModding::get()->handleModifications(alpha::utils::cocos::getChildByClassName(node, type, index).value_or(nullptr), value);
+    UIModding::get()->handleModifications(Utils::getChildByClassName(node, type, index).value_or(nullptr), value);
 }
 
 void UIModding::createAndModifyNewChild(CCNode* node, const matjson::Value& newChildVal) {

src/Utils.hpp

@@ -236,6 +236,35 @@ namespace Utils {
         return extract(std::string(name));
     }
 
+    static std::optional<cocos2d::CCNode*> getChildByClassName(cocos2d::CCNode* node, geode::ZStringView name, int index = 0) {
+        if (!node || node->getChildrenCount() == 0) return nullptr;
+
+        size_t indexCounter = 0;
+        const size_t childrenCount = node->getChildrenCount();
+
+        bool isNegativeIndex = (index < 0);
+        if (isNegativeIndex) {
+            index = -index - 1; 
+        }
+
+        for (size_t i = (isNegativeIndex ? childrenCount - 1 : 0); 
+            isNegativeIndex ? i >= 0 : i < childrenCount; 
+            isNegativeIndex ? --i : ++i) {
+
+            auto idxNode = node->getChildrenExt()[i];
+            if (getObjectName(idxNode) == name) {
+                if (indexCounter == index) {
+                    return idxNode;
+                }
+                ++indexCounter;
+            }
+
+            if (isNegativeIndex && i == 0) break;
+        }
+
+        return std::nullopt;
+    }
+
     static CCNode* nodeForQuery(CCNode* node, const std::string& queryStr) {
         auto res = NodeQuery::parse(queryStr);
         if (!res) return nullptr;