small internal changes

Author: AlphiiGD

src/hooks/GManager.cpp

@@ -1,6 +1,12 @@
 #include "GManager.hpp"
 #include "../utils/GDPSMain.hpp"
 
+#ifdef GEODE_IS_IOS
+    static constexpr const char* const gdpsesPath = "save/gdpses";
+#else
+    static constexpr const char* const gdpsesPath = "gdpses";
+#endif
+
 std::vector<GSGManager*> GSGManager::Fields::m_managers = {};
 
 void GSGManager::setup() {
@@ -30,11 +36,7 @@ void GSGManager::setup() {
             return log::error("Error after creating directory '{}', data will not save: {}", dir.string(), err.message());
         }
     }
-    #ifdef GEODE_IS_IOS
-    m_fileName = fmt::format("save/gdpses/{}/{}", server.saveDir, m_fileName);
-    #else
-    m_fileName = fmt::format("gdpses/{}/{}", server.saveDir, m_fileName);
-    #endif
+    m_fileName = fmt::format("{}/{}/{}", gdpsesPath, server.saveDir, m_fileName);
     GManager::setup();
 }
 
@@ -68,11 +70,7 @@ void GSGManager::updateFileNames() {
             }
         }
         if (main->isActive()) {
-            #ifdef GEODE_IS_IOS
-            manager->m_fileName = fmt::format("save/gdpses/{}/{}", server.saveDir, manager->m_fields->m_originalFileName);
-            #else
-            manager->m_fileName = fmt::format("gdpses/{}/{}", server.saveDir, manager->m_fields->m_originalFileName);
-            #endif
+            manager->m_fileName = fmt::format("{}/{}/{}", gdpsesPath, server.saveDir, manager->m_fields->m_originalFileName);
         }
     }
 }

src/ui/BonusSettingsPopup.cpp

@@ -26,7 +26,7 @@ using namespace geode::prelude;
     } \
     m_scroll->m_contentLayer->addChild(var); \
     m_options.push_back(var); \
-    odd = !odd;
+    odd = !odd
 
 #define makeToggle(var, text, id, value, default, callback) \
     CCMenu* var = CCMenu::create(); \
@@ -51,7 +51,7 @@ using namespace geode::prelude;
     } \
     m_scroll->m_contentLayer->addChild(var); \
     m_options.push_back(var); \
-    odd = !odd;
+    odd = !odd
 
 bool BonusSettingsPopup::setup() {
     m_scroll = ScrollLayer::create({360, 240});
@@ -73,11 +73,11 @@ bool BonusSettingsPopup::setup() {
     makeToggle(nintendoSwitcher, "Nintendo Switcher (2025 april fools)", "nintendo-switcher-toggle", "ss-nintendo-switcher", false, [this](CCMenuItemToggler *toggler){
         Mod::get()->setSavedValue("ss-nintendo-switcher", !toggler->m_toggled);
         m_reloadLayer = true;
-    })
+    });
     makeToggle(rainbow, "Rainbow Nodes", "rainbow-toggle", "ss-rainbow", false, [this](CCMenuItemToggler *toggler){
 	Mod::get()->setSavedValue("ss-rainbow", !toggler->m_toggled);
         m_reloadLayer = true;
-    })
+    });
     makeButton(hideBtn, "hide-button", "Deactivate Menu", "GJ_button_01.png", [this](auto){ 
         geode::createQuickPopup("Are you sure?", "Are you sure you want to disable the secret settings?", "Cancel", "Yes", [this](FLAlertLayer* popup, bool second){
             if (second) {
@@ -94,7 +94,7 @@ bool BonusSettingsPopup::setup() {
                 }
             }
         });
-    })
+    });
 
     m_scroll->m_contentLayer->updateLayout();
     float y = 0;

src/utils/MigrationManager.cpp

@@ -28,8 +28,9 @@ Result<> MigrationManager::setup() {
     return Ok();
 }
 
-std::string MigrationManager::urlToFilenameSafe(const std::string url) {
+std::string MigrationManager::urlToFilenameSafe(std::string_view url) {
     std::string ret = "";
+    ret.reserve(url.size());
     for (char c : url) {
         if (std::isalnum(c) || c == '.' || c == '-' || c == '_') {
             ret += c;
@@ -46,7 +47,7 @@ void MigrationManager::migrateData() {
     auto main = GDPSMain::get();
     auto oldSel = Mod::get()->getSavedValue<std::string>("server", "https://www.boomlings.com/database/");
 
-    for (auto old : Mod::get()->getSavedValue<std::vector<GDPSTypes::OldServer>>("saved-servers")) {
+    for (auto& old : Mod::get()->getSavedValue<std::vector<GDPSTypes::OldServer>>("saved-servers")) {
         auto serv = fromOldServer(old);
         main->m_servers[serv.id] = serv;
         if (oldSel == serv.url) {

src/utils/MigrationManager.hpp

@@ -14,5 +14,5 @@ class MigrationManager {
         GDPSTypes::Server fromOldServer(GDPSTypes::OldServer server);
     public:
         Result<> setup();
-        static std::string urlToFilenameSafe(std::string url);
+        static std::string urlToFilenameSafe(std::string_view url);
 };