fix failing tests

Author: PlayJeri

src/__tests__/clanInventory/room/RoomService/readAllSoulHomeRooms.test.ts

@@ -39,9 +39,7 @@ describe('Room.readAllSoulHomeRooms() test suite', () => {
     const clearedRoom = clearDBRespDefaultFields(room);
 
     expect(errors).toBeNull();
-    expect(clearedRoom).toEqual(
-      expect.objectContaining([existingRoom1, existingRoom2]),
-    );
+    expect(clearedRoom).toEqual([existingRoom1, existingRoom2]);
   });
 
   it('Should return NOT_FOUND if soul home does not exists', async () => {

src/__tests__/clanInventory/room/RoomService/readPlayerClanRooms.test.ts

@@ -61,9 +61,7 @@ describe('Room.readPlayerClanRooms() test suite', () => {
     const clearedRoom = clearDBRespDefaultFields(room);
 
     expect(errors).toBeNull();
-    expect(clearedRoom).toEqual(
-      expect.objectContaining([existingRoom1, existingRoom2]),
-    );
+    expect(clearedRoom).toEqual([existingRoom1, existingRoom2]);
   });
 
   it('Should return NOT_FOUND if player does not exists', async () => {

src/__tests__/clanInventory/room/utils/RoomHelperService/getPlayerRooms.test.ts

@@ -59,9 +59,7 @@ describe('RoomHelperService.getPlayerRooms() test suite', () => {
     const clearedRooms = clearDBRespDefaultFields(rooms);
 
     expect(errors).toBeNull();
-    expect(clearedRooms).toEqual(
-      expect.objectContaining([existingRoom1, existingRoom2]),
-    );
+    expect(clearedRooms).toEqual([existingRoom1, existingRoom2]);
   });
 
   it('Should return NOT_FOUND if player does not exists', async () => {

src/__tests__/itemMover/ItemMoverService/stealItems.test.ts

@@ -102,7 +102,6 @@ describe('ItemMoverService.stealItems() test suite', () => {
     );
   });
 
-  //TODO: should return items with updated room_ids
   it('Should return moved items', async () => {
     const [movedItems, errors] = await itemMoverService.stealItems(
       [item1._id, item2._id],
@@ -120,7 +119,6 @@ describe('ItemMoverService.stealItems() test suite', () => {
     );
   });
 
-  //TODO: Should throw No movable items found
   it('Should throw NOT_FOUND ServiceError if provided items do not exist', async () => {
     const throwingCall = async () => {
       await itemMoverService.stealItems(
@@ -133,7 +131,7 @@ describe('ItemMoverService.stealItems() test suite', () => {
     await expect(throwingCall).rejects.toThrow(
       new APIError({
         reason: APIErrorReason.NOT_FOUND,
-        message: "Cannot read properties of undefined (reading 'soulHomeId')",
+        message: 'No movable items found',
       }),
     );
   });
@@ -159,7 +157,7 @@ describe('ItemMoverService.stealItems() test suite', () => {
     await expect(throwingCall).rejects.toThrow(
       new APIError({
         reason: APIErrorReason.NOT_FOUND,
-        message: "Cannot read properties of null (reading 'map')",
+        message: 'No movable items found',
       }),
     );
   });
@@ -176,7 +174,7 @@ describe('ItemMoverService.stealItems() test suite', () => {
     await expect(throwingCall).rejects.toThrow(
       new APIError({
         reason: APIErrorReason.NOT_FOUND,
-        message: "Cannot read properties of undefined (reading 'map')",
+        message: 'No movable items found',
       }),
     );
   });

src/itemMover/itemMover.service.ts

@@ -127,18 +127,25 @@ export class ItemMoverService {
    * @throws - Throws an error if no movable items are found.
    */
   async stealItems(itemIds: string[], stealToken: StealToken, roomId: string) {
-    const itemSoulHomeIds: { itemId: string; soulHomeId: string }[] =
+    if (!Array.isArray(itemIds) || itemIds.length === 0) {
+      throw new APIError({
+        reason: APIErrorReason.NOT_FOUND,
+        message: 'No movable items found',
+      });
+    }
+    const itemSoulHomeIds: { itemId: string; soulHomeId: string }[] = (
       await Promise.all(
         itemIds.map(async (itemId) => {
           try {
             const soulHomeId =
               await this.itemHelperService.getItemSoulHomeId(itemId);
             return { itemId, soulHomeId };
-          } catch (e) {
-            void e;
+          } catch {
+            return undefined;
           }
         }),
-      );
+      )
+    ).filter(Boolean);
 
     const filteredItems = itemSoulHomeIds.filter(
       (item) => item.soulHomeId === stealToken.soulHomeId,