Skip to content

Commit 0023b28

Browse files
andy-shevrafaeljw
authored andcommitted
ACPI: sysfs: Refactor param_get_trace_state() to drop dead code
The param_get_trace_state() has a few dead code issues: - 'return 0;' is never reachable - a few 'else' keywords are redundant Refactor param_get_trace_state() to drop dead code. Note, leave one 'else' in order to have the best readability. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent b272c05 commit 0023b28

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

drivers/acpi/sysfs.c

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -255,16 +255,12 @@ static int param_get_trace_state(char *buffer, const struct kernel_param *kp)
255255
{
256256
if (!(acpi_gbl_trace_flags & ACPI_TRACE_ENABLED))
257257
return sprintf(buffer, "disable\n");
258-
else {
259-
if (acpi_gbl_trace_method_name) {
260-
if (acpi_gbl_trace_flags & ACPI_TRACE_ONESHOT)
261-
return sprintf(buffer, "method-once\n");
262-
else
263-
return sprintf(buffer, "method\n");
264-
} else
265-
return sprintf(buffer, "enable\n");
266-
}
267-
return 0;
258+
if (!acpi_gbl_trace_method_name)
259+
return sprintf(buffer, "enable\n");
260+
if (acpi_gbl_trace_flags & ACPI_TRACE_ONESHOT)
261+
return sprintf(buffer, "method-once\n");
262+
else
263+
return sprintf(buffer, "method\n");
268264
}
269265

270266
module_param_call(trace_state, param_set_trace_state, param_get_trace_state,

0 commit comments

Comments
 (0)