Skip to content

Commit 0319b84

Browse files
geertutorvalds
authored andcommitted
binfmt: a.out: Fix bogus semicolon
fs/binfmt_aout.c: In function ‘load_aout_library’: fs/binfmt_aout.c:311:27: error: expected ‘)’ before ‘;’ token 311 | MAP_FIXED | MAP_PRIVATE; | ^ fs/binfmt_aout.c:309:10: error: too few arguments to function ‘vm_mmap’ 309 | error = vm_mmap(file, start_addr, ex.a_text + ex.a_data, | ^~~~~~~ In file included from fs/binfmt_aout.c:12: include/linux/mm.h:2626:35: note: declared here 2626 | extern unsigned long __must_check vm_mmap(struct file *, unsigned long, | ^~~~~~~ Fix this by reverting the accidental replacement of a comma by a semicolon. Fixes: 42be8b4 ("binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()") Reported-by: [email protected] Reported-by: Guenter Roeck <[email protected]> Signed-off-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 49624ef commit 0319b84

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/binfmt_aout.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ static int load_aout_library(struct file *file)
308308
/* Now use mmap to map the library into memory. */
309309
error = vm_mmap(file, start_addr, ex.a_text + ex.a_data,
310310
PROT_READ | PROT_WRITE | PROT_EXEC,
311-
MAP_FIXED | MAP_PRIVATE;
311+
MAP_FIXED | MAP_PRIVATE,
312312
N_TXTOFF(ex));
313313
retval = error;
314314
if (error != start_addr)

0 commit comments

Comments
 (0)