Skip to content

Commit 03a2753

Browse files
marckleinebuddelynxeye-dev
authored andcommitted
drm/etnaviv: dump: fix sparse warnings
This patch fixes the following sparse warnings, by adding the missing endianess conversion functions. | etnaviv/etnaviv_dump.c:78:26: warning: restricted __le32 degrades to integer | etnaviv/etnaviv_dump.c:88:26: warning: incorrect type in assignment (different base types) | etnaviv/etnaviv_dump.c:88:26: expected restricted __le32 [usertype] reg | etnaviv/etnaviv_dump.c:88:26: got unsigned short const | etnaviv/etnaviv_dump.c:89:28: warning: incorrect type in assignment (different base types) | etnaviv/etnaviv_dump.c:89:28: expected restricted __le32 [usertype] value | etnaviv/etnaviv_dump.c:89:28: got unsigned int | etnaviv/etnaviv_dump.c:210:43: warning: incorrect type in assignment (different base types) | etnaviv/etnaviv_dump.c:210:43: expected restricted __le32 | etnaviv/etnaviv_dump.c:210:43: got long Signed-off-by: Marc Kleine-Budde <[email protected]> Signed-off-by: Lucas Stach <[email protected]>
1 parent 1ff79a4 commit 03a2753

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/etnaviv/etnaviv_dump.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ static void etnaviv_core_dump_header(struct core_dump_iterator *iter,
7575
hdr->file_size = cpu_to_le32(data_end - iter->data);
7676

7777
iter->hdr++;
78-
iter->data += hdr->file_size;
78+
iter->data += le32_to_cpu(hdr->file_size);
7979
}
8080

8181
static void etnaviv_core_dump_registers(struct core_dump_iterator *iter,
@@ -85,8 +85,8 @@ static void etnaviv_core_dump_registers(struct core_dump_iterator *iter,
8585
unsigned int i;
8686

8787
for (i = 0; i < ARRAY_SIZE(etnaviv_dump_registers); i++, reg++) {
88-
reg->reg = etnaviv_dump_registers[i];
89-
reg->value = gpu_read(gpu, etnaviv_dump_registers[i]);
88+
reg->reg = cpu_to_le32(etnaviv_dump_registers[i]);
89+
reg->value = cpu_to_le32(gpu_read(gpu, etnaviv_dump_registers[i]));
9090
}
9191

9292
etnaviv_core_dump_header(iter, ETDUMP_BUF_REG, reg);
@@ -207,7 +207,7 @@ void etnaviv_core_dump(struct etnaviv_gem_submit *submit)
207207
if (!IS_ERR(pages)) {
208208
int j;
209209

210-
iter.hdr->data[0] = bomap - bomap_start;
210+
iter.hdr->data[0] = cpu_to_le32((bomap - bomap_start));
211211

212212
for (j = 0; j < obj->base.size >> PAGE_SHIFT; j++)
213213
*bomap++ = cpu_to_le64(page_to_phys(*pages++));

0 commit comments

Comments
 (0)