Skip to content

Commit 0475838

Browse files
arndbLee Jones
authored andcommitted
backlight: journada720: Fix Wmisleading-indentation warning
With gcc-11, we get a warning about code that looks correct but badly indented: drivers/video/backlight/jornada720_bl.c: In function ‘jornada_bl_update_status’: drivers/video/backlight/jornada720_bl.c:66:11: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation] 66 | } else /* turn on backlight */ | ^~~~ Change the formatting according to our normal conventions. Fixes: 13a7b5d ("backlight: Adds HP Jornada 700 series backlight driver") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Daniel Thompson <[email protected]> Signed-off-by: Lee Jones <[email protected]>
1 parent 5eb622e commit 0475838

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

drivers/video/backlight/jornada720_bl.c

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -66,30 +66,30 @@ static int jornada_bl_update_status(struct backlight_device *bd)
6666
} else /* turn on backlight */
6767
PPSR |= PPC_LDD1;
6868

69-
/* send command to our mcu */
70-
if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) {
71-
dev_info(&bd->dev, "failed to set brightness\n");
72-
ret = -ETIMEDOUT;
73-
goto out;
74-
}
69+
/* send command to our mcu */
70+
if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) {
71+
dev_info(&bd->dev, "failed to set brightness\n");
72+
ret = -ETIMEDOUT;
73+
goto out;
74+
}
7575

76-
/*
77-
* at this point we expect that the mcu has accepted
78-
* our command and is waiting for our new value
79-
* please note that maximum brightness is 255,
80-
* but due to physical layout it is equal to 0, so we simply
81-
* invert the value (MAX VALUE - NEW VALUE).
82-
*/
83-
if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness)
84-
!= TXDUMMY) {
85-
dev_err(&bd->dev, "set brightness failed\n");
86-
ret = -ETIMEDOUT;
87-
}
76+
/*
77+
* at this point we expect that the mcu has accepted
78+
* our command and is waiting for our new value
79+
* please note that maximum brightness is 255,
80+
* but due to physical layout it is equal to 0, so we simply
81+
* invert the value (MAX VALUE - NEW VALUE).
82+
*/
83+
if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness)
84+
!= TXDUMMY) {
85+
dev_err(&bd->dev, "set brightness failed\n");
86+
ret = -ETIMEDOUT;
87+
}
8888

89-
/*
90-
* If infact we get an TXDUMMY as output we are happy and dont
91-
* make any further comments about it
92-
*/
89+
/*
90+
* If infact we get an TXDUMMY as output we are happy and dont
91+
* make any further comments about it
92+
*/
9393
out:
9494
jornada_ssp_end();
9595

0 commit comments

Comments
 (0)