clk: imx: Reference preceded by free

Jian Dong · abelvesa · commit 054ef44ea3ef · 2021-04-04T22:39:05.000+03:00
When register failed, clk will be freed, it will generate dangling pointer
problem in later reference. it should return directly.

Signed-off-by: Jian Dong &lt;dongjian@yulong.com&gt;
Signed-off-by: Abel Vesa &lt;abel.vesa@nxp.com&gt;
diff --git a/drivers/clk/imx/clk-lpcg-scu.c b/drivers/clk/imx/clk-lpcg-scu.c
@@ -114,6 +114,7 @@ struct clk_hw *__imx_clk_lpcg_scu(struct device *dev, const char *name,
 	if (ret) {
 		kfree(clk);
 		hw = ERR_PTR(ret);
+		return hw;
 	}
 
 	if (dev)
diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
@@ -426,6 +426,7 @@ struct clk_hw *__imx_clk_scu(struct device *dev, const char *name,
 	if (ret) {
 		kfree(clk);
 		hw = ERR_PTR(ret);
+		return hw;
 	}
 
 	if (dev)

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ struct clk_hw __imx_clk_lpcg_scu(struct device dev, const char *name,`
`114`	`114`	`if (ret) {`
`115`	`115`	`kfree(clk);`
`116`	`116`	`hw = ERR_PTR(ret);`
	`117`	`+ return hw;`
`117`	`118`	`}`
`118`	`119`
`119`	`120`	`if (dev)`
Original file line number	Diff line number	Diff line change
`@@ -426,6 +426,7 @@ struct clk_hw __imx_clk_scu(struct device dev, const char *name,`
`426`	`426`	`if (ret) {`
`427`	`427`	`kfree(clk);`
`428`	`428`	`hw = ERR_PTR(ret);`
	`429`	`+ return hw;`
`429`	`430`	`}`
`430`	`431`
`431`	`432`	`if (dev)`