Skip to content

Commit 0afd6a4

Browse files
Michael Chandavem330
authored andcommitted
bnxt_en: Rediscover PHY capabilities after firmware reset
There is a missing bnxt_probe_phy() call in bnxt_fw_init_one() to rediscover the PHY capabilities after a firmware reset. This can cause some PHY related functionalities to fail after a firmware reset. For example, in multi-host, the ability for any host to configure the PHY settings may be lost after a firmware reset. Fixes: ec5d31e ("bnxt_en: Handle firmware reset status during IF_UP.") Signed-off-by: Michael Chan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 39eb028 commit 0afd6a4

File tree

1 file changed

+5
-0
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+5
-0
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11750,6 +11750,8 @@ static void bnxt_fw_init_one_p3(struct bnxt *bp)
1175011750
bnxt_hwrm_coal_params_qcaps(bp);
1175111751
}
1175211752

11753+
static int bnxt_probe_phy(struct bnxt *bp, bool fw_dflt);
11754+
1175311755
static int bnxt_fw_init_one(struct bnxt *bp)
1175411756
{
1175511757
int rc;
@@ -11764,6 +11766,9 @@ static int bnxt_fw_init_one(struct bnxt *bp)
1176411766
netdev_err(bp->dev, "Firmware init phase 2 failed\n");
1176511767
return rc;
1176611768
}
11769+
rc = bnxt_probe_phy(bp, false);
11770+
if (rc)
11771+
return rc;
1176711772
rc = bnxt_approve_mac(bp, bp->dev->dev_addr, false);
1176811773
if (rc)
1176911774
return rc;

0 commit comments

Comments
 (0)