Skip to content

Commit 12a0cf7

Browse files
committed
Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
Pull i2c fixes from Wolfram Sang: "A mixture of driver and documentation bugfixes for I2C" * 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: i2c: imx: mention Oleksij as maintainer of the binding docs i2c: exynos5: correct top kerneldoc i2c: designware: Adjust bus_freq_hz when refuse high speed mode set i2c: hix5hd2: use the correct HiSilicon copyright i2c: gpio: update email address in binding docs i2c: imx: drop me as maintainer of binding docs i2c: stm32f4: Mundane typo fix I2C: JZ4780: Fix bug for Ingenic X1000. i2c: turn recovery error on init to debug
2 parents d496177 + df8a39f commit 12a0cf7

File tree

8 files changed

+12
-10
lines changed

8 files changed

+12
-10
lines changed

Documentation/devicetree/bindings/i2c/i2c-gpio.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
77
title: Bindings for GPIO bitbanged I2C
88

99
maintainers:
10-
- Wolfram Sang <[email protected]>
10+
- Wolfram Sang <[email protected]>
1111

1212
allOf:
1313
- $ref: /schemas/i2c/i2c-controller.yaml#

Documentation/devicetree/bindings/i2c/i2c-imx.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
77
title: Freescale Inter IC (I2C) and High Speed Inter IC (HS-I2C) for i.MX
88

99
maintainers:
10-
- Wolfram Sang <wolfram@the-dreams.de>
10+
- Oleksij Rempel <o.rempel@pengutronix.de>
1111

1212
allOf:
1313
- $ref: /schemas/i2c/i2c-controller.yaml#

drivers/i2c/busses/i2c-designware-master.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
129129
if ((comp_param1 & DW_IC_COMP_PARAM_1_SPEED_MODE_MASK)
130130
!= DW_IC_COMP_PARAM_1_SPEED_MODE_HIGH) {
131131
dev_err(dev->dev, "High Speed not supported!\n");
132+
t->bus_freq_hz = I2C_MAX_FAST_MODE_FREQ;
132133
dev->master_cfg &= ~DW_IC_CON_SPEED_MASK;
133134
dev->master_cfg |= DW_IC_CON_SPEED_FAST;
134135
dev->hs_hcnt = 0;

drivers/i2c/busses/i2c-exynos5.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// SPDX-License-Identifier: GPL-2.0-only
2-
/**
2+
/*
33
* i2c-exynos5.c - Samsung Exynos5 I2C Controller Driver
44
*
55
* Copyright (C) 2013 Samsung Electronics Co., Ltd.

drivers/i2c/busses/i2c-hix5hd2.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-License-Identifier: GPL-2.0-or-later
22
/*
33
* Copyright (c) 2014 Linaro Ltd.
4-
* Copyright (c) 2014 Hisilicon Limited.
4+
* Copyright (c) 2014 HiSilicon Limited.
55
*
66
* Now only support 7 bit address.
77
*/

drivers/i2c/busses/i2c-jz4780.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,8 +525,8 @@ static irqreturn_t jz4780_i2c_irq(int irqno, void *dev_id)
525525
i2c_sta = jz4780_i2c_readw(i2c, JZ4780_I2C_STA);
526526
data = *i2c->wbuf;
527527
data &= ~JZ4780_I2C_DC_READ;
528-
if ((!i2c->stop_hold) && (i2c->cdata->version >=
529-
ID_X1000))
528+
if ((i2c->wt_len == 1) && (!i2c->stop_hold) &&
529+
(i2c->cdata->version >= ID_X1000))
530530
data |= X1000_I2C_DC_STOP;
531531
jz4780_i2c_writew(i2c, JZ4780_I2C_DC, data);
532532
i2c->wbuf++;

drivers/i2c/busses/i2c-stm32f4.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ static void stm32f4_i2c_handle_rx_addr(struct stm32f4_i2c_dev *i2c_dev)
534534
default:
535535
/*
536536
* N-byte reception:
537-
* Enable ACK, reset POS (ACK postion) and clear ADDR flag.
537+
* Enable ACK, reset POS (ACK position) and clear ADDR flag.
538538
* In that way, ACK will be sent as soon as the current byte
539539
* will be received in the shift register
540540
*/

drivers/i2c/i2c-core-base.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ static int i2c_gpio_init_recovery(struct i2c_adapter *adap)
378378
static int i2c_init_recovery(struct i2c_adapter *adap)
379379
{
380380
struct i2c_bus_recovery_info *bri = adap->bus_recovery_info;
381-
char *err_str;
381+
char *err_str, *err_level = KERN_ERR;
382382

383383
if (!bri)
384384
return 0;
@@ -387,7 +387,8 @@ static int i2c_init_recovery(struct i2c_adapter *adap)
387387
return -EPROBE_DEFER;
388388

389389
if (!bri->recover_bus) {
390-
err_str = "no recover_bus() found";
390+
err_str = "no suitable method provided";
391+
err_level = KERN_DEBUG;
391392
goto err;
392393
}
393394

@@ -414,7 +415,7 @@ static int i2c_init_recovery(struct i2c_adapter *adap)
414415

415416
return 0;
416417
err:
417-
dev_err(&adap->dev, "Not using recovery: %s\n", err_str);
418+
dev_printk(err_level, &adap->dev, "Not using recovery: %s\n", err_str);
418419
adap->bus_recovery_info = NULL;
419420

420421
return -EINVAL;

0 commit comments

Comments
 (0)